Fix for physics lock-up in 1.21.4#3883
Open
sampritchard03 wants to merge 1 commit into
Open
Conversation
During my testing, bots on at least 1.21.4 will permanently lock up when hit by an arrow. This is because prismarine physics returns NaN for pos.x and pos.z. This fix just rejects unsafe physics ticks.
|
well whats the fucking fix |
Contributor
|
this fix is a stop measure, review #3889 for the actual fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my testing (and also documented here: #3882), bots on at least 1.21.4 will permanently lock up when hit by an arrow. This is because prismarine physics returns NaN for pos.x and pos.z. This edit just catches and rejects the illegal position, shouldn't affect anything that already works.