fix checkbox/radio handler

Author: suskind

package.json

@@ -1,6 +1,6 @@
 {
   "name": "snyk-api-and-web-record-sequence",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Snyk API & Web Record login/sequence",
   "license": "MIT",
   "scripts": {

src/manifest-firefox.json

@@ -1,6 +1,6 @@
 {
   "name": "Snyk API & Web Sequence Recorder",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "browser_specific_settings": {
     "gecko": {
       "id": "sequence-recorder@probely.com",

src/pages/Content/modules/collectEvents.js

@@ -201,17 +201,26 @@ export function interceptEvents(event, doc, ifrSelector, callback) {
     }
     const parentLabel = tgt.closest && tgt.closest('label');
     if (parentLabel) {
-      const forAttr = parentLabel.getAttribute('for');
-      if (forAttr) {
-        const forEl = document.getElementById(forAttr);
-        if (forEl && forEl.nodeName.toLowerCase() === 'input' &&
-          (forEl.type === 'checkbox' || forEl.type === 'radio')) {
+      // Only suppress when the click is actually forwarded to the labeled control.
+      // Clicks on interactive descendants (links, buttons, other fields) are NOT
+      // forwarded by the browser and must still be recorded.
+      const interactiveHit = tgt.closest('a, button, input, select, textarea');
+      const forwardsToControl = !interactiveHit || !parentLabel.contains(interactiveHit);
+      if (forwardsToControl) {
+        const forAttr = parentLabel.getAttribute('for');
+        if (forAttr) {
+          const root = tgt.getRootNode();
+          const lookup = root && root.getElementById ? root : document; // shadow-DOM safe
+          const forEl = lookup.getElementById(forAttr);
+          if (forEl && forEl.nodeName.toLowerCase() === 'input' &&
+            (forEl.type === 'checkbox' || forEl.type === 'radio')) {
+            return;
+          }
+        }
+        if (parentLabel.querySelector('input[type="checkbox"], input[type="radio"]')) {
           return;
         }
       }
-      if (parentLabel.querySelector('input[type="checkbox"], input[type="radio"]')) {
-        return;
-      }
     }
     let typeStr = 'click';
     if (isCanvasSurface(tgt)) {

test-build-firefox/contentScript.bundle.js

@@ -1,6 +1,6 @@
 {
   "name": "Snyk API & Web Sequence Recorder",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "browser_specific_settings": {
     "gecko": {
       "id": "sequence-recorder@probely.com",

test-build-firefox/manifest.json

@@ -1 +1 @@
-{"version":"1.2.1","manifest_version":3,"name":"Snyk API & Web Sequence Recorder","action":{"default_popup":"popup.html","default_icon":{"16":"icon-34.png","48":"icon-48.png"}},"icons":{"128":"icon-128.png"},"background":{"service_worker":"background.bundle.js"},"content_scripts":[{"matches":["http://*/*","https://*/*"],"js":["contentScript.bundle.js"],"css":["content.styles.css"],"run_at":"document_start","all_frames":true,"match_about_blank":true}],"web_accessible_resources":[{"resources":["content.styles.css","icon-128.png","icon-34.png"],"matches":["<all_urls>"]}],"permissions":["storage","activeTab"],"host_permissions":["http://*/*","https://*/*"]}
+{"version":"1.2.2","manifest_version":3,"name":"Snyk API & Web Sequence Recorder","action":{"default_popup":"popup.html","default_icon":{"16":"icon-34.png","48":"icon-48.png"}},"icons":{"128":"icon-128.png"},"background":{"service_worker":"background.bundle.js"},"content_scripts":[{"matches":["http://*/*","https://*/*"],"js":["contentScript.bundle.js"],"css":["content.styles.css"],"run_at":"document_start","all_frames":true,"match_about_blank":true}],"web_accessible_resources":[{"resources":["content.styles.css","icon-128.png","icon-34.png"],"matches":["<all_urls>"]}],"permissions":["storage","activeTab"],"host_permissions":["http://*/*","https://*/*"]}