v1.2.2 - Improve checkbox event. Update example file (#16)

* v1.2.2 - Improve checkbox event. Update example file

* fix checkbox/radio handler

Author: suskind

OUTPUT-EXAMPLE.md

@@ -1,4 +1,4 @@
-# Result Example
+# Output Example
 
 JSON example containing all possible step types produced by the sequence recorder.
 
@@ -124,6 +124,14 @@ JSON example containing all possible step types produced by the sequence recorde
     "type": "click",
     "value": "Submit",
     "frame": "#content-iframe"
+  },
+  {
+    "timestamp": 1718724013000,
+    "css": ".nested-btn",
+    "xpath": "/html/body/div/button",
+    "type": "click",
+    "value": "Confirm",
+    "frame": "#outer-iframe >>> #inner-iframe"
   }
 ]
 ```
@@ -153,4 +161,4 @@ JSON example containing all possible step types produced by the sequence recorde
 | `xpath` | XPath selector for the target element |
 | `type` | Event type identifier |
 | `value` | Element value or trimmed text content (max 20 chars for clicks) |
-| `frame` | CSS selector of the containing iframe, empty string if top-level |
+| `frame` | CSS selector of the containing iframe, empty string if top-level. For nested iframes, selectors are joined with ` >>> ` from outermost to innermost (e.g. `#outer-iframe >>> #inner-iframe`) |

package.json

@@ -1,6 +1,6 @@
 {
   "name": "snyk-api-and-web-record-sequence",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "description": "Snyk API & Web Record login/sequence",
   "license": "MIT",
   "scripts": {

src/manifest-firefox.json

@@ -1,6 +1,6 @@
 {
   "name": "Snyk API & Web Sequence Recorder",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "browser_specific_settings": {
     "gecko": {
       "id": "sequence-recorder@probely.com",

src/pages/Content/modules/collectEvents.js

@@ -199,11 +199,27 @@ export function interceptEvents(event, doc, ifrSelector, callback) {
     ) {
       return;
     }
-    if (nodeName === 'label') {
-      const forAttr = tgt.getAttribute('for');
-      if (forAttr && document.getElementById(forAttr)) {
-        // can be ignored... will fire checkbox
-        return;
+    const parentLabel = tgt.closest && tgt.closest('label');
+    if (parentLabel) {
+      // Only suppress when the click is actually forwarded to the labeled control.
+      // Clicks on interactive descendants (links, buttons, other fields) are NOT
+      // forwarded by the browser and must still be recorded.
+      const interactiveHit = tgt.closest('a, button, input, select, textarea');
+      const forwardsToControl = !interactiveHit || !parentLabel.contains(interactiveHit);
+      if (forwardsToControl) {
+        const forAttr = parentLabel.getAttribute('for');
+        if (forAttr) {
+          const root = tgt.getRootNode();
+          const lookup = root && root.getElementById ? root : document; // shadow-DOM safe
+          const forEl = lookup.getElementById(forAttr);
+          if (forEl && forEl.nodeName.toLowerCase() === 'input' &&
+            (forEl.type === 'checkbox' || forEl.type === 'radio')) {
+            return;
+          }
+        }
+        if (parentLabel.querySelector('input[type="checkbox"], input[type="radio"]')) {
+          return;
+        }
       }
     }
     let typeStr = 'click';

test-build-firefox/contentScript.bundle.js

@@ -1,6 +1,6 @@
 {
   "name": "Snyk API & Web Sequence Recorder",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "browser_specific_settings": {
     "gecko": {
       "id": "sequence-recorder@probely.com",

test-build-firefox/manifest.json

@@ -1 +1 @@
-{"version":"1.2.0","manifest_version":3,"name":"Snyk API & Web Sequence Recorder","action":{"default_popup":"popup.html","default_icon":{"16":"icon-34.png","48":"icon-48.png"}},"icons":{"128":"icon-128.png"},"background":{"service_worker":"background.bundle.js"},"content_scripts":[{"matches":["http://*/*","https://*/*"],"js":["contentScript.bundle.js"],"css":["content.styles.css"],"run_at":"document_start","all_frames":true,"match_about_blank":true}],"web_accessible_resources":[{"resources":["content.styles.css","icon-128.png","icon-34.png"],"matches":["<all_urls>"]}],"permissions":["storage","activeTab"],"host_permissions":["http://*/*","https://*/*"]}
+{"version":"1.2.2","manifest_version":3,"name":"Snyk API & Web Sequence Recorder","action":{"default_popup":"popup.html","default_icon":{"16":"icon-34.png","48":"icon-48.png"}},"icons":{"128":"icon-128.png"},"background":{"service_worker":"background.bundle.js"},"content_scripts":[{"matches":["http://*/*","https://*/*"],"js":["contentScript.bundle.js"],"css":["content.styles.css"],"run_at":"document_start","all_frames":true,"match_about_blank":true}],"web_accessible_resources":[{"resources":["content.styles.css","icon-128.png","icon-34.png"],"matches":["<all_urls>"]}],"permissions":["storage","activeTab"],"host_permissions":["http://*/*","https://*/*"]}