-
Notifications
You must be signed in to change notification settings - Fork 0
Add capability security failure taxonomy labels #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ProfRandom92
merged 1 commit into
main
from
codex/add-capability-security-failure-taxonomy-labels
May 20, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -76,3 +76,14 @@ def test_registered_labels_do_not_use_banned_fuzzy_terms() -> None: | |||||
| normalized = label.lower() | ||||||
| for banned in BANNED_FUZZY_TERMS: | ||||||
| assert banned not in normalized, f"label '{label}' contains banned fuzzy term '{banned}'" | ||||||
|
|
||||||
|
|
||||||
| def test_capability_security_expansion_labels_are_registered() -> None: | ||||||
| expected_labels = { | ||||||
| "CAPABILITY_BOUNDARY_LOSS", | ||||||
| "UNAUTHORIZED_CAPABILITY_PATH", | ||||||
| "APPROVAL_GATE_LOSS", | ||||||
| "POLICY_ENFORCEMENT_GAP", | ||||||
| } | ||||||
| missing = sorted(label for label in expected_labels if label not in FAILURE_TAXONOMY) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic to find missing labels can be expressed more concisely and idiomatically using set operations. This is also generally more performant for large collections.
Suggested change
|
||||||
| assert not missing, f"expected capability/security labels missing from taxonomy: {missing}" | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
severity_classvalues "safety" and "governance" are inconsistent with the existing values (critical,high,medium) used in the taxonomy. This could cause confusion as they seem to represent categories rather than severity levels.To improve clarity and maintainability, please consider mapping these to the existing severity scale. For example:
CAPABILITY_BOUNDARY_LOSSandUNAUTHORIZED_CAPABILITY_PATHseem to becriticalissues.APPROVAL_GATE_LOSSandPOLICY_ENFORCEMENT_GAPseem to behighseverity issues.If "safety" and "governance" are intended as new classification axes, it might be better to introduce a separate field for them to avoid overloading the meaning of
severity_class.