Ensure PHP 8.1 compatibility

Remove readonly modifier
Remove class constants with native types

ERM20742

Author: HamishSlater

.github/workflows/ci-php.yml

@@ -24,7 +24,7 @@ jobs:
       matrix:
         include:
           - mw: 'REL1_43'
-            php: '8.3'
+            php: '8.1'
 
     runs-on: ubuntu-latest
 
@@ -112,15 +112,15 @@ jobs:
         run: php tests/phpunit/phpunit.php -c extensions/NeoWiki/phpunit.xml.dist
 
   phpcs:
-    name: "PHPCS with PHP 8.3"
+    name: "PHPCS with PHP 8.1"
 
     runs-on: ubuntu-latest
 
     steps:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.3
+          php-version: 8.1
 
       - name: Checkout NeoExtension
         uses: actions/checkout@v6
@@ -138,7 +138,7 @@ jobs:
       matrix:
         include:
           - mw: 'REL1_43'
-            php: '8.3'
+            php: '8.1'
 
     runs-on: ubuntu-latest
 
@@ -204,7 +204,7 @@ jobs:
 #      matrix:
 #        include:
 #          - mw: 'master'
-#            php: '8.3'
+#            php: '8.1'
 #
 #    runs-on: ubuntu-latest
 #

composer.json

@@ -16,7 +16,7 @@
 		}
 	],
 	"require": {
-		"php": "^8.3",
+		"php": "^8.1",
 		"composer/installers": "^2|^1.0.1",
 		"opis/json-schema": "^2.3.0",
 		"laudis/neo4j-php-client": "^3.1.2",

src/Application/Actions/CreateSubject/CreateSubjectAction.php

@@ -17,7 +17,7 @@
 use ProfessionalWiki\NeoWiki\Application\SubjectAuthorizer;
 use RuntimeException;
 
-readonly class CreateSubjectAction {
+class CreateSubjectAction {
 
 	public function __construct(
 		private CreateSubjectPresenter $presenter,

src/Application/Actions/CreateSubject/CreateSubjectRequest.php

@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Application\Actions\CreateSubject;
 
-readonly class CreateSubjectRequest {
+class CreateSubjectRequest {
 
 	public function __construct(
 		public int $pageId,

src/Application/Actions/DeleteSubject/DeleteSubjectAction.php

@@ -8,7 +8,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectId;
 use ProfessionalWiki\NeoWiki\Application\SubjectAuthorizer;
 
-readonly class DeleteSubjectAction {
+class DeleteSubjectAction {
 
 	public function __construct(
 		private SubjectRepository $subjectRepository,

src/Application/Actions/PatchSubject/PatchSubjectAction.php

@@ -14,7 +14,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectLabel;
 use RuntimeException;
 
-readonly class PatchSubjectAction {
+class PatchSubjectAction {
 
 	public function __construct(
 		private SubjectRepository $subjectRepository,

src/Application/Actions/SetMainSubject/SetMainSubjectAction.php

@@ -11,7 +11,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Subject\Subject;
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectId;
 
-readonly class SetMainSubjectAction {
+class SetMainSubjectAction {
 
 	public function __construct(
 		private SetMainSubjectPresenter $presenter,

src/Application/Actions/SetMainSubject/SetMainSubjectRequest.php

@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Application\Actions\SetMainSubject;
 
-readonly class SetMainSubjectRequest {
+class SetMainSubjectRequest {
 
 	public function __construct(
 		public int $pageId,

src/Application/CompositeCypherQueryValidator.php

@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Application;
 
-readonly class CompositeCypherQueryValidator implements CypherQueryValidator {
+class CompositeCypherQueryValidator implements CypherQueryValidator {
 
 	/**
 	 * @param CypherQueryValidator[] $validators

src/Application/Queries/GetLayout/GetLayoutQuery.php

@@ -8,7 +8,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Layout\LayoutName;
 use ProfessionalWiki\NeoWiki\Presentation\LayoutPresentationSerializer;
 
-readonly class GetLayoutQuery {
+class GetLayoutQuery {
 
 	public function __construct(
 		private GetLayoutPresenter $presenter,