Remove readonly modifier to maintain PHP 8.1 compatibility

HamishSlater · HamishSlater · commit fb52173e0be0 · 2026-04-30T20:33:01.000+07:00
ERM20742
diff --git a/.github/workflows/ci-php.yml b/.github/workflows/ci-php.yml
@@ -24,7 +24,7 @@ jobs:
       matrix:
         include:
           - mw: 'REL1_43'
-            php: '8.3'
+            php: '8.1'
 
     runs-on: ubuntu-latest
 
@@ -112,15 +112,15 @@ jobs:
         run: php tests/phpunit/phpunit.php -c extensions/NeoWiki/phpunit.xml.dist
 
   phpcs:
-    name: "PHPCS with PHP 8.3"
+    name: "PHPCS with PHP 8.1"
 
     runs-on: ubuntu-latest
 
     steps:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.3
+          php-version: 8.1
 
       - name: Checkout NeoExtension
         uses: actions/checkout@v6
@@ -138,7 +138,7 @@ jobs:
       matrix:
         include:
           - mw: 'REL1_43'
-            php: '8.3'
+            php: '8.1'
 
     runs-on: ubuntu-latest
 
@@ -204,7 +204,7 @@ jobs:
 #      matrix:
 #        include:
 #          - mw: 'master'
-#            php: '8.3'
+#            php: '8.1'
 #
 #    runs-on: ubuntu-latest
 #
diff --git a/composer.json b/composer.json
@@ -16,7 +16,7 @@
 		}
 	],
 	"require": {
-		"php": "^8.3",
+		"php": "^8.1",
 		"composer/installers": "^2|^1.0.1",
 		"opis/json-schema": "^2.3.0",
 		"laudis/neo4j-php-client": "^3.1.2",
diff --git a/src/Application/Actions/CreateSubject/CreateSubjectAction.php b/src/Application/Actions/CreateSubject/CreateSubjectAction.php
@@ -17,7 +17,7 @@
 use ProfessionalWiki\NeoWiki\Application\SubjectAuthorizer;
 use RuntimeException;
 
-readonly class CreateSubjectAction {
+class CreateSubjectAction {
 
 	public function __construct(
 		private CreateSubjectPresenter $presenter,
diff --git a/src/Application/Actions/CreateSubject/CreateSubjectRequest.php b/src/Application/Actions/CreateSubject/CreateSubjectRequest.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Application\Actions\CreateSubject;
 
-readonly class CreateSubjectRequest {
+class CreateSubjectRequest {
 
 	public function __construct(
 		public int $pageId,
diff --git a/src/Application/Actions/DeleteSubject/DeleteSubjectAction.php b/src/Application/Actions/DeleteSubject/DeleteSubjectAction.php
@@ -8,7 +8,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectId;
 use ProfessionalWiki\NeoWiki\Application\SubjectAuthorizer;
 
-readonly class DeleteSubjectAction {
+class DeleteSubjectAction {
 
 	public function __construct(
 		private SubjectRepository $subjectRepository,
diff --git a/src/Application/Actions/PatchSubject/PatchSubjectAction.php b/src/Application/Actions/PatchSubject/PatchSubjectAction.php
@@ -14,7 +14,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectLabel;
 use RuntimeException;
 
-readonly class PatchSubjectAction {
+class PatchSubjectAction {
 
 	public function __construct(
 		private SubjectRepository $subjectRepository,
diff --git a/src/Application/Actions/SetMainSubject/SetMainSubjectAction.php b/src/Application/Actions/SetMainSubject/SetMainSubjectAction.php
@@ -11,7 +11,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Subject\Subject;
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectId;
 
-readonly class SetMainSubjectAction {
+class SetMainSubjectAction {
 
 	public function __construct(
 		private SetMainSubjectPresenter $presenter,
diff --git a/src/Application/Actions/SetMainSubject/SetMainSubjectRequest.php b/src/Application/Actions/SetMainSubject/SetMainSubjectRequest.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Application\Actions\SetMainSubject;
 
-readonly class SetMainSubjectRequest {
+class SetMainSubjectRequest {
 
 	public function __construct(
 		public int $pageId,
diff --git a/src/Application/CompositeCypherQueryValidator.php b/src/Application/CompositeCypherQueryValidator.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Application;
 
-readonly class CompositeCypherQueryValidator implements CypherQueryValidator {
+class CompositeCypherQueryValidator implements CypherQueryValidator {
 
 	/**
 	 * @param CypherQueryValidator[] $validators
diff --git a/src/Application/Queries/GetLayout/GetLayoutQuery.php b/src/Application/Queries/GetLayout/GetLayoutQuery.php
@@ -8,7 +8,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Layout\LayoutName;
 use ProfessionalWiki\NeoWiki\Presentation\LayoutPresentationSerializer;
 
-readonly class GetLayoutQuery {
+class GetLayoutQuery {
 
 	public function __construct(
 		private GetLayoutPresenter $presenter,
diff --git a/src/Application/Queries/GetPageSubjects/GetPageSubjectsQuery.php b/src/Application/Queries/GetPageSubjects/GetPageSubjectsQuery.php
@@ -15,7 +15,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Subject\Subject;
 use ProfessionalWiki\NeoWiki\Presentation\SchemaPresentationSerializer;
 
-readonly class GetPageSubjectsQuery {
+class GetPageSubjectsQuery {
 
 	public function __construct(
 		private GetPageSubjectsPresenter $presenter,
diff --git a/src/Application/Queries/GetPageSubjects/GetPageSubjectsResponse.php b/src/Application/Queries/GetPageSubjects/GetPageSubjectsResponse.php
@@ -6,7 +6,7 @@
 
 use ProfessionalWiki\NeoWiki\Application\Queries\GetSubject\GetSubjectResponseItem;
 
-readonly class GetPageSubjectsResponse {
+class GetPageSubjectsResponse {
 
 	public function __construct(
 		public int $pageId,
diff --git a/src/Application/Queries/GetSchema/GetSchemaQuery.php b/src/Application/Queries/GetSchema/GetSchemaQuery.php
@@ -8,7 +8,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Schema\SchemaName;
 use ProfessionalWiki\NeoWiki\Presentation\SchemaPresentationSerializer;
 
-readonly class GetSchemaQuery {
+class GetSchemaQuery {
 
 	public function __construct(
 		private GetSchemaPresenter $presenter,
diff --git a/src/Application/Queries/GetSubject/GetSubjectQuery.php b/src/Application/Queries/GetSubject/GetSubjectQuery.php
@@ -10,7 +10,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Subject\Subject;
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectId;
 
-readonly class GetSubjectQuery {
+class GetSubjectQuery {
 
 	public function __construct(
 		private GetSubjectPresenter $presenter,
diff --git a/src/Application/Queries/GetSubject/GetSubjectResponse.php b/src/Application/Queries/GetSubject/GetSubjectResponse.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Application\Queries\GetSubject;
 
-readonly class GetSubjectResponse {
+class GetSubjectResponse {
 
 	public function __construct(
 		public string $requestedId,
diff --git a/src/Application/Queries/GetSubject/GetSubjectResponseItem.php b/src/Application/Queries/GetSubject/GetSubjectResponseItem.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Application\Queries\GetSubject;
 
-readonly class GetSubjectResponseItem {
+class GetSubjectResponseItem {
 
 	public function __construct(
 		public string $id,
diff --git a/src/Application/SelectPatchResolver.php b/src/Application/SelectPatchResolver.php
@@ -16,7 +16,7 @@
  * Leaves non-select entries, deletions (null), and properties not found
  * on the Schema untouched.
  */
-readonly class SelectPatchResolver {
+class SelectPatchResolver {
 
 	public function __construct(
 		private SelectValueResolver $valueResolver,
diff --git a/src/Application/SelectValueResolver.php b/src/Application/SelectValueResolver.php
@@ -8,7 +8,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Schema\Property\SelectOption;
 use ProfessionalWiki\NeoWiki\Domain\Schema\Property\SelectProperty;
 
-readonly class SelectValueResolver {
+class SelectValueResolver {
 
 	/**
 	 * Resolves a raw input value (id, label, or {id,label} object) to the canonical option ID.
diff --git a/src/Application/StatementListPatcher.php b/src/Application/StatementListPatcher.php
@@ -20,7 +20,7 @@
 use ProfessionalWiki\NeoWiki\Domain\PropertyType\PropertyTypeToValueType;
 use ProfessionalWiki\NeoWiki\Infrastructure\IdGenerator;
 
-readonly class StatementListPatcher {
+class StatementListPatcher {
 
 	public function __construct(
 		private PropertyTypeToValueType $propertyTypeToValueType,
diff --git a/src/Domain/Layout/DisplayRule.php b/src/Domain/Layout/DisplayRule.php
@@ -6,7 +6,7 @@
 
 use ProfessionalWiki\NeoWiki\Domain\Schema\PropertyName;
 
-readonly class DisplayRule {
+class DisplayRule {
 
 	/**
 	 * @param array<string, mixed> $displayAttributes
diff --git a/src/Domain/Layout/Layout.php b/src/Domain/Layout/Layout.php
@@ -6,7 +6,7 @@
 
 use ProfessionalWiki\NeoWiki\Domain\Schema\SchemaName;
 
-readonly class Layout {
+class Layout {
 
 	/**
 	 * @param array<string, mixed> $settings
diff --git a/src/Domain/Layout/LayoutName.php b/src/Domain/Layout/LayoutName.php
@@ -6,7 +6,7 @@
 
 use InvalidArgumentException;
 
-readonly class LayoutName {
+class LayoutName {
 
 	public function __construct(
 		private string $text,
diff --git a/src/Domain/Page/Page.php b/src/Domain/Page/Page.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Page;
 
-readonly class Page {
+class Page {
 
 	public function __construct(
 		private PageId $id,
diff --git a/src/Domain/Page/PageDateTime.php b/src/Domain/Page/PageDateTime.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Page;
 
-readonly class PageDateTime implements PageValue {
+class PageDateTime implements PageValue {
 
 	/**
 	 * @param string $timestamp In the standard MediaWiki format, ie 20230726163439
diff --git a/src/Domain/Page/PageId.php b/src/Domain/Page/PageId.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Page;
 
-readonly class PageId {
+class PageId {
 
 	public function __construct(
 		public int $id
diff --git a/src/Domain/Page/PageIdentifiers.php b/src/Domain/Page/PageIdentifiers.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Page;
 
-readonly class PageIdentifiers {
+class PageIdentifiers {
 
 	public function __construct(
 		private PageId $id,
diff --git a/src/Domain/Page/PageProperties.php b/src/Domain/Page/PageProperties.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Page;
 
-readonly class PageProperties {
+class PageProperties {
 
 	/**
 	 * @param array<string, mixed> $properties
diff --git a/src/Domain/Page/PagePropertyProviderContext.php b/src/Domain/Page/PagePropertyProviderContext.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Page;
 
-readonly class PagePropertyProviderContext {
+class PagePropertyProviderContext {
 
 	/**
 	 * @param string $pageTitle Page title text without namespace prefix, e.g. "My Page" not "Talk:My Page"
diff --git a/src/Domain/PropertyType/PropertyTypeToValueType.php b/src/Domain/PropertyType/PropertyTypeToValueType.php
@@ -7,7 +7,7 @@
 use OutOfBoundsException;
 use ProfessionalWiki\NeoWiki\Domain\Value\ValueType;
 
-readonly class PropertyTypeToValueType {
+class PropertyTypeToValueType {
 
 	public function __construct(
 		private PropertyTypeLookup $registry
diff --git a/src/Domain/Relation/Relation.php b/src/Domain/Relation/Relation.php
@@ -6,7 +6,7 @@
 
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectId;
 
-readonly class Relation {
+class Relation {
 
 	public function __construct(
 		public RelationId $id,
diff --git a/src/Domain/Relation/RelationId.php b/src/Domain/Relation/RelationId.php
@@ -6,7 +6,7 @@
 
 use ProfessionalWiki\NeoWiki\Infrastructure\IdGenerator;
 
-readonly class RelationId {
+class RelationId {
 
 	private string $text;
 
diff --git a/src/Domain/Relation/RelationProperties.php b/src/Domain/Relation/RelationProperties.php
@@ -6,7 +6,7 @@
 
 use InvalidArgumentException;
 
-readonly class RelationProperties {
+class RelationProperties {
 
 	public function __construct(
 		/**
diff --git a/src/Domain/Relation/RelationType.php b/src/Domain/Relation/RelationType.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Relation;
 
-readonly class RelationType {
+class RelationType {
 
 	public function __construct(
 		public string $text,
diff --git a/src/Domain/Relation/TypedRelation.php b/src/Domain/Relation/TypedRelation.php
@@ -6,7 +6,7 @@
 
 use ProfessionalWiki\NeoWiki\Domain\Subject\SubjectId;
 
-readonly class TypedRelation {
+class TypedRelation {
 
 	public function __construct(
 		public RelationId $id,
diff --git a/src/Domain/Relation/TypedRelationList.php b/src/Domain/Relation/TypedRelationList.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Relation;
 
-readonly class TypedRelationList {
+class TypedRelationList {
 
 	public function __construct(
 		/**
diff --git a/src/Domain/Schema/PropertyCore.php b/src/Domain/Schema/PropertyCore.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Schema;
 
-readonly class PropertyCore {
+class PropertyCore {
 
 	/**
 	 * A null default means there is no default.
diff --git a/src/Domain/Schema/PropertyName.php b/src/Domain/Schema/PropertyName.php
@@ -4,7 +4,7 @@
 
 namespace ProfessionalWiki\NeoWiki\Domain\Schema;
 
-readonly class PropertyName {
+class PropertyName {
 
 	public function __construct(
 		public string $text
diff --git a/src/Domain/Schema/Schema.php b/src/Domain/Schema/Schema.php
@@ -7,7 +7,7 @@
 use OutOfBoundsException;
 use ProfessionalWiki\NeoWiki\Domain\PropertyType\Types\RelationType;
 
-readonly class Schema {
+class Schema {
 
 	public function __construct(
 		private SchemaName $name,
diff --git a/src/Domain/Schema/SchemaName.php b/src/Domain/Schema/SchemaName.php
@@ -6,7 +6,7 @@
 
 use InvalidArgumentException;
 
-readonly class SchemaName {
+class SchemaName {
 
 	private const array RESERVED_NAMES = [
 		'page',
diff --git a/src/Domain/Statement.php b/src/Domain/Statement.php
@@ -7,7 +7,7 @@
 use ProfessionalWiki\NeoWiki\Domain\Schema\PropertyName;
 use ProfessionalWiki\NeoWiki\Domain\Value\NeoValue;
 
-readonly class Statement {
+class Statement {
 
 	public function __construct(
 		private PropertyName $property,
diff --git a/src/Domain/Subject/StatementList.php b/src/Domain/Subject/StatementList.php
diff --git a/src/Domain/Subject/SubjectId.php b/src/Domain/Subject/SubjectId.php
diff --git a/src/Domain/Subject/SubjectIdList.php b/src/Domain/Subject/SubjectIdList.php
diff --git a/src/Domain/Subject/SubjectLabel.php b/src/Domain/Subject/SubjectLabel.php
diff --git a/src/Domain/Value/BooleanValue.php b/src/Domain/Value/BooleanValue.php
diff --git a/src/Domain/Value/NumberValue.php b/src/Domain/Value/NumberValue.php
diff --git a/src/Domain/Value/RelationValue.php b/src/Domain/Value/RelationValue.php
diff --git a/src/Domain/Value/StringValue.php b/src/Domain/Value/StringValue.php
diff --git a/src/EntryPoints/NeoWikiRegistrar.php b/src/EntryPoints/NeoWikiRegistrar.php
diff --git a/src/NeoWikiConfig.php b/src/NeoWikiConfig.php
diff --git a/src/PagePropertiesBuilder.php b/src/PagePropertiesBuilder.php
diff --git a/src/Persistence/Neo4j/ExplainCypherQueryValidator.php b/src/Persistence/Neo4j/ExplainCypherQueryValidator.php
diff --git a/src/Persistence/Neo4j/Neo4jQueryStore.php b/src/Persistence/Neo4j/Neo4jQueryStore.php

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`}`
`17`	`17`	`],`
`18`	`18`	`"require": {`
`19`		`- "php": "^8.3",`
	`19`	`+ "php": "^8.1",`
`20`	`20`	`"composer/installers": "^2\|^1.0.1",`
`21`	`21`	`"opis/json-schema": "^2.3.0",`
`22`	`22`	`"laudis/neo4j-php-client": "^3.1.2",`