Fix CI for MW master compatibility

- Use per-matrix search engine images: Elasticsearch 7.10 for
  REL1_43–REL1_45, OpenSearch 1.3 for master (CirrusSearch dropped
  Elasticsearch support on master)
- Handle MW master's removal of tests/phpunit/phpunit.php by falling
  back to composer phpunit
- Download phpunit.xml.template in install script since GitHub tarballs
  exclude it via .gitattributes export-ignore
- Stop using removed SpecialPageTestBase, extend
  MediaWikiIntegrationTestCase directly
- Pass PageIdentity instead of LinkTarget to getRevisionByTitle
  (deprecated since MW 1.36, enforced on master)
- Bump cache key version and mark master as non-experimental

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: JeroenDeDauw

.github/workflows/ci.yml

@@ -16,34 +16,40 @@ jobs:
             php: '8.1'
             experimental: false
             coverage: false
+            search-image: 'docker-registry.wikimedia.org/repos/search-platform/cirrussearch-elasticsearch-image:v7.10.2-12'
           - mw: 'REL1_43'
             php: '8.2'
             experimental: false
             coverage: true
+            search-image: 'docker-registry.wikimedia.org/repos/search-platform/cirrussearch-elasticsearch-image:v7.10.2-12'
           - mw: 'REL1_44'
             php: '8.3'
             experimental: false
             coverage: false
+            search-image: 'docker-registry.wikimedia.org/repos/search-platform/cirrussearch-elasticsearch-image:v7.10.2-12'
           - mw: 'REL1_45'
             php: '8.4'
             experimental: false
             coverage: false
+            search-image: 'docker-registry.wikimedia.org/repos/search-platform/cirrussearch-elasticsearch-image:v7.10.2-12'
           - mw: 'master'
             php: '8.5'
-            experimental: true
+            experimental: false
             coverage: false
+            search-image: 'docker-registry.wikimedia.org/repos/search-platform/cirrussearch-opensearch-image:v1.3.20-12'
 
     runs-on: ubuntu-latest
 
     services:
       elasticsearch:
-        image: docker-registry.wikimedia.org/releng/cirrus-elasticsearch:7.10.2-s0 # Compatibility info at https://www.mediawiki.org/wiki/Extension:CirrusSearch
+        image: ${{ matrix.search-image }}
         ports:
           - 9200:9200
           - 9300:9300
         env:
           discovery.type: single-node
           ES_JAVA_OPTS: "-Xms512m -Xmx512m -Dlog4j2.formatMsgNoLookups=true"
+          OPENSEARCH_JAVA_OPTS: "-Xms512m -Xmx512m"
 
     defaults:
       run:
@@ -65,7 +71,7 @@ jobs:
             mediawiki
             !mediawiki/extensions/
             !mediawiki/vendor/
-          key: mw_${{ matrix.mw }}-php${{ matrix.php }}_v2
+          key: mw_${{ matrix.mw }}-php${{ matrix.php }}_v3
 
       - name: Cache Composer cache
         uses: actions/cache@v4
@@ -101,11 +107,21 @@ jobs:
           php maintenance/runJobs.php
 
       - name: Run PHPUnit
-        run: php tests/phpunit/phpunit.php -c extensions/WikibaseFacetedSearch/
+        run: |
+          if [ -f tests/phpunit/phpunit.php ]; then
+            php tests/phpunit/phpunit.php -c extensions/WikibaseFacetedSearch/
+          else
+            composer phpunit -- extensions/WikibaseFacetedSearch/tests/
+          fi
         if: ${{ ! matrix.coverage }}
 
       - name: Run PHPUnit with code coverage
-        run: php tests/phpunit/phpunit.php -c extensions/WikibaseFacetedSearch/ --coverage-clover coverage.xml
+        run: |
+          if [ -f tests/phpunit/phpunit.php ]; then
+            php tests/phpunit/phpunit.php -c extensions/WikibaseFacetedSearch/ --coverage-clover coverage.xml
+          else
+            composer phpunit -- extensions/WikibaseFacetedSearch/tests/ --coverage-clover coverage.xml
+          fi
         if: ${{ matrix.coverage }}
 
       - name: Upload code coverage
@@ -145,7 +161,7 @@ jobs:
             mediawiki
             mediawiki/extensions/
             mediawiki/vendor/
-          key: mw_${{ matrix.mw }}-php${{ matrix.php }}_v2
+          key: mw_${{ matrix.mw }}-php${{ matrix.php }}_v3
 
       - name: Cache Composer cache
         uses: actions/cache@v4
@@ -214,7 +230,7 @@ jobs:
         uses: actions/cache@v4
         with:
           path: ~/.composer/cache
-          key: mw_${{ matrix.mw }}-php${{ matrix.php }}_v2
+          key: mw_${{ matrix.mw }}-php${{ matrix.php }}_v3
 
       - name: Install MediaWiki
         if: steps.cache-mediawiki.outputs.cache-hit != 'true'

.github/workflows/installMediaWiki.sh

@@ -12,6 +12,12 @@ mv mediawiki-$MW_BRANCH mediawiki
 
 cd mediawiki
 
+# phpunit.xml.template is excluded from GitHub tarballs via .gitattributes export-ignore.
+# Download it directly from the repo if missing.
+if [ ! -f phpunit.xml.template ]; then
+    wget "https://raw.githubusercontent.com/wikimedia/mediawiki/$MW_BRANCH/phpunit.xml.template" -nv -O phpunit.xml.template 2>/dev/null || true
+fi
+
 composer install
 php maintenance/install.php --dbtype sqlite --dbuser root --dbname mw --dbpath $(pwd) --pass AdminPassword WikiName AdminUser
 

src/Persistence/PageContentFetcher.php

@@ -8,6 +8,7 @@
 use MediaWiki\Revision\RevisionLookup;
 use MediaWiki\Revision\SlotRecord;
 use MediaWiki\Title\MalformedTitleException;
+use MediaWiki\Title\Title;
 use MediaWiki\Title\TitleParser;
 
 class PageContentFetcher {
@@ -20,7 +21,7 @@ public function __construct(
 
 	public function getPageContent( string $pageTitle ): ?Content {
 		try {
-			$title = $this->titleParser->parseTitle( $pageTitle );
+			$title = Title::newFromLinkTarget( $this->titleParser->parseTitle( $pageTitle ) );
 		} catch ( MalformedTitleException ) {
 			return null;
 		}

tests/phpunit/EntryPoints/SpecialWikibaseFacetedSearchConfigTest.php

@@ -4,28 +4,22 @@
 
 namespace ProfessionalWiki\WikibaseFacetedSearch\Tests\EntryPoints;
 
-use MediaWiki\SpecialPage\SpecialPage;
 use MediaWiki\Title\Title;
 use ProfessionalWiki\WikibaseFacetedSearch\WikibaseFacetedSearchExtension;
-use SpecialPageTestBase;
 
 /**
  * @covers \ProfessionalWiki\WikibaseFacetedSearch\EntryPoints\SpecialWikibaseFacetedSearchConfig
  */
-class SpecialWikibaseFacetedSearchConfigTest extends SpecialPageTestBase {
-
-	protected function newSpecialPage(): SpecialPage {
-		return $this->getServiceContainer()->getSpecialPageFactory()->getPage( 'WikibaseFacetedSearchConfig' );
-	}
+class SpecialWikibaseFacetedSearchConfigTest extends \MediaWikiIntegrationTestCase {
 
 	public function testRedirect(): void {
-		$specialRules = $this->newSpecialPage();
+		$specialPage = $this->getServiceContainer()->getSpecialPageFactory()->getPage( 'WikibaseFacetedSearchConfig' );
 
-		$specialRules->execute( null );
+		$specialPage->execute( null );
 
 		$this->assertEquals(
 			Title::newFromText( WikibaseFacetedSearchExtension::CONFIG_PAGE_TITLE, NS_MEDIAWIKI )->getFullURL(),
-			$specialRules->getOutput()->getRedirect()
+			$specialPage->getOutput()->getRedirect()
 		);
 	}