Fix CI for MW master: tolerate absent Wikibase JS submodules#283
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #283 +/- ##
=========================================
Coverage 74.07% 74.07%
Complexity 399 399
=========================================
Files 47 47
Lines 1292 1292
=========================================
Hits 957 957
Misses 335 335 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The MW master CI job aborted in installMediaWiki.sh with exit 128:
fatal: no submodule mapping found in .gitmodules for path 'view/lib/wikibase-serialization'
Wikibase master removed the wikibase-serialization, wikibase-data-values and
wikibase-data-model view-layer submodules (migrated to npm), so `git submodule
set-url` on those paths fails. Under `set -e` this aborted the install before
PHPUnit ran, and fail-fast then cancelled every other matrix job.
These JS libraries are not needed by the PHP test suite. Make the URL rewrites
tolerant of an absent submodule so the script no longer aborts on master, while
behaviour on REL1_43/44/45 (where the submodules still exist) is unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
malberts
force-pushed
the
fix/ci-mw-master-wikibase-submodules
branch
from
e5bcb9e to
9ef9663
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude Code, Opus 4.8 (1M context). @JeroenDeDauw spotted that CI fails for the MW master matrix job and asked for a simple fix. Context: the WikibaseFacetedSearch codebase, its CI workflow and failing run logs, and Wikibase's
.gitmodulesonmastervs theREL1_*branches.The MW master CI job aborted in
installMediaWiki.shwith exit 128:Wikibase master removed the
wikibase-serialization,wikibase-data-valuesandwikibase-data-modelview-layer submodules (migrated to npm), sogit submodule set-urlon those paths fails. Underset -ethis aborted the install before PHPUnit ran, and fail-fast then cancelled every other matrix job.These JS libraries are not needed by the PHP test suite. Make the URL rewrites tolerant of an absent submodule so the script no longer aborts on master, while behaviour on REL1_43/44/45 (where the submodules still exist) is unchanged.
🤖 Generated with Claude Code