fix all errors

Author: ProgrammerKR

scripts/setup_llvm_windows.ps1

@@ -4,7 +4,16 @@
 function Resolve-LLVMLayout {
     $candidateRoots = New-Object System.Collections.Generic.List[string]
 
-    # Check if llvm-config is already in PATH
+    # 1. Direct LLVM_ROOT or LLVM_DIR environment variables
+    if ($env:LLVM_ROOT -and (Test-Path $env:LLVM_ROOT)) { $candidateRoots.Add($env:LLVM_ROOT) }
+    if ($env:LLVM_DIR -and (Test-Path $env:LLVM_DIR)) {
+        # If LLVM_DIR points to cmake dir, root is likely 2 or 3 levels up
+        $dir = $env:LLVM_DIR
+        $candidateRoots.Add((Split-Path (Split-Path (Split-Path $dir)))) # lib/cmake/llvm -> lib/cmake -> lib -> root
+        $candidateRoots.Add((Split-Path (Split-Path $dir)))              # cmake -> root
+    }
+
+    # 2. Check if llvm-config is in PATH
     $llvmConfig = Get-Command llvm-config -ErrorAction SilentlyContinue
     if ($llvmConfig) {
         $binPath = $llvmConfig.Source
@@ -13,11 +22,12 @@ function Resolve-LLVMLayout {
         $candidateRoots.Add($root)
     }
 
-    # Common installation paths
+    # 3. Known installation paths
     $candidateRoots.Add("C:\Program Files\LLVM")
     $candidateRoots.Add("C:\Program Files (x86)\LLVM")
     $candidateRoots.Add("C:\ProgramData\chocolatey\lib\llvm\tools\llvm")
     $candidateRoots.Add("C:\ProgramData\chocolatey\lib\llvm")
+    $candidateRoots.Add("C:\tools\llvm")
 
     if ($env:ChocolateyInstall) {
         $candidateRoots.Add((Join-Path $env:ChocolateyInstall "lib\llvm\tools\llvm"))
@@ -28,11 +38,13 @@ function Resolve-LLVMLayout {
         "lib\cmake\llvm",
         "lib\llvm\cmake",
         "share\llvm\cmake",
-        "cmake"
+        "cmake",
+        "lib\cmake"
     )
 
-    foreach ($root in ($candidateRoots | Select-Object -Unique)) {
-        if (-not $root -or -not (Test-Path $root)) { continue }
+    $uniqueRoots = $candidateRoots | Where-Object { $_ -ne $null -and $_ -ne "" } | Select-Object -Unique
+    foreach ($root in $uniqueRoots) {
+        if (-not (Test-Path $root)) { continue }
 
         Write-Host "Checking LLVM root candidate: $root"
         foreach ($suffix in $cmakeSuffixes) {
@@ -47,28 +59,30 @@ function Resolve-LLVMLayout {
         }
     }
 
-    # Fallback: Recursive search in Program Files if still not found
+    # 4. Fallback: Recursive search in common areas
     Write-Host "Performing exhaustive search for LLVMConfig.cmake..."
-    $searchRoots = @("C:\Program Files", "C:\Program Files (x86)", "C:\ProgramData\chocolatey\lib")
+    $searchRoots = @("C:\Program Files", "C:\Program Files (x86)", "C:\ProgramData\chocolatey", "C:\tools")
     foreach ($sr in $searchRoots) {
         if (-not (Test-Path $sr)) { continue }
-        $configFile = Get-ChildItem -Path $sr -Filter "LLVMConfig.cmake" -Recurse -ErrorAction SilentlyContinue | Select-Object -First 1
+        $configFile = Get-ChildItem -Path $sr -Filter "LLVMConfig.cmake" -Recurse -Depth 4 -ErrorAction SilentlyContinue | Select-Object -First 1
         if ($configFile) {
             $cmakeDir = $configFile.DirectoryName
             Write-Host "Found LLVMConfig.cmake at: $cmakeDir"
-            # Try to find the root by going up from cmake dir
+            
+            # Try to find the root by looking for 'bin' nearby
             $root = $cmakeDir
             for ($i = 0; $i -lt 4; $i++) {
-                if (Test-Path (Join-Path $root "bin")) { break }
+                if (Test-Path (Join-Path $root "bin")) { 
+                    return @{
+                        Root = $root
+                        CMakeDir = $cmakeDir
+                        BinDir = Join-Path $root "bin"
+                    }
+                }
                 $parent = Split-Path -Parent $root
                 if ($parent -eq $root) { break }
                 $root = $parent
             }
-            return @{
-                Root = $root
-                CMakeDir = $cmakeDir
-                BinDir = Join-Path $root "bin"
-            }
         }
     }
     return $null
@@ -80,7 +94,8 @@ $layout = Resolve-LLVMLayout
 # 2. Install if not found
 if (-not $layout) {
     Write-Host "LLVM not initially found. Installing via Chocolatey..."
-    choco install llvm -y --version 17.0.6 --allow-downgrade --no-progress --limit-output
+    # Using --params to add LLVM to PATH
+    choco install llvm -y --version 17.0.6 --allow-downgrade --no-progress --limit-output --package-parameters="\"/InstallDir:C:\LLVM\""
 
     # Refresh PATH for the current session
     Write-Host "Refreshing PATH..."
@@ -106,6 +121,7 @@ if ($layout) {
 
     Write-Host "Resolved LLVM root: $llvmRoot"
     Write-Host "Resolved LLVM_DIR: $cmakeDir"
+    Write-Host "Resolved BinDir: $binDir"
 
     if ($env:GITHUB_ENV) {
         Add-Content $env:GITHUB_ENV "LLVM_DIR=$cmakeDir"
@@ -117,9 +133,17 @@ if ($layout) {
         Add-Content $env:GITHUB_PATH $binDir
     }
 } else {
-    Write-Host "DUMPING COMMON LOCATIONS FOR DEBUG:"
-    Get-ChildItem "C:\Program Files" -ErrorAction SilentlyContinue | Select-Object Name
-    Get-ChildItem "C:\ProgramData\chocolatey\lib" -ErrorAction SilentlyContinue | Select-Object Name
-    Write-Error "Failed to detect LLVM after installation."
+    Write-Host "`n--- DEBUG INFO: SEARCH FAILED ---"
+    Write-Host "Listing top-level directories for clues:"
+    $debugPaths = @("C:\Program Files", "C:\Program Files (x86)", "C:\ProgramData\chocolatey\lib", "C:\LLVM", "C:\tools")
+    foreach ($dp in $debugPaths) {
+        if (Test-Path $dp) {
+            Write-Host "`nContents of $dp`:"
+            Get-ChildItem $dp -ErrorAction SilentlyContinue | Select-Object Name | Format-Table -HideTableHeaders
+        }
+    }
+    
+    Write-Error "Failed to detect LLVM after installation. Check logs above for directory contents."
     exit 1
 }
+