Conversation
magdalena-grubesa
left a comment
There was a problem hiding this comment.
- Can the package be installed? Yes, I was able to install it in a virtual environment
- Is the vignette set up correctly? Yes, it contains all the necessary information and good examples.
- Did the unit tests run? yes
- Did they pass? yes
erwardenaar
reviewed
May 27, 2026
erwardenaar
left a comment
There was a problem hiding this comment.
- Can the package be installed?
Yes, cleanly. One note: the README clone instructions point to main, so a user following them gets the old stub version, not the week-3 code. Worth noting the branch or merging.
- Is the vignette set up correctly?
Yes, it is well structured, covers purpose, users, workflow, and examples. The dependency table in the vignette is actually more complete than the README (it includes sentence-transformers, benepar, etc.), so it might be worth syncing the README to match.
- Did the unit tests run? Did they pass?
All 31 pass. The tests themselves are great: 5 files, proper mocking, fixtures, edge cases, error paths for parsers and scorers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.