Skip to content

Commit 03d743a

Browse files
authored
Merge pull request #529 from ProgressPlanner/filip/v16/fix-snooze-overlay
2 parents 3aec230 + 7016b5f commit 03d743a

3 files changed

Lines changed: 3 additions & 33 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
Bugs we fixed:
44

55
* "Collect your point" not closing the "Test if your website can send emails correctly" popover.
6+
* Snooze task tooltip overaly not closing properly.
67

78
= 1.6.0 =
89

assets/js/suggested-task.js

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -436,37 +436,6 @@ prplSuggestedTask = {
436436
}
437437

438438
switch ( action ) {
439-
case 'snooze':
440-
tooltipActions
441-
.querySelector( elClass )
442-
?.setAttribute( 'data-tooltip-visible', 'true' );
443-
break;
444-
445-
case 'close-snooze':
446-
// Close the radio group.
447-
tooltipActions
448-
.querySelector(
449-
`${ elClass }.prpl-toggle-radio-group-open`
450-
)
451-
?.classList.remove( 'prpl-toggle-radio-group-open' );
452-
// Close the tooltip.
453-
tooltipActions
454-
.querySelector( `${ elClass }[data-tooltip-visible]` )
455-
?.removeAttribute( 'data-tooltip-visible' );
456-
break;
457-
458-
case 'info':
459-
tooltipActions
460-
.querySelector( elClass )
461-
?.setAttribute( 'data-tooltip-visible', 'true' );
462-
break;
463-
464-
case 'close-info':
465-
tooltipActions
466-
.querySelector( elClass )
467-
.removeAttribute( 'data-tooltip-visible' );
468-
break;
469-
470439
case 'move-up':
471440
case 'move-down':
472441
if ( 'move-up' === action && item.previousElementSibling ) {

views/js-templates/suggested-task.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ <h3 style="width: 100%;">
2929
<# if ( data.post.content.rendered !== '' ) { #>
3030
<prpl-tooltip>
3131
<slot name="open-icon">
32-
<button type="button" class="prpl-suggested-task-button" data-task-id="{{ data.post.meta.prpl_task_id }}" data-task-title="{{ data.post.title.rendered }}" data-action="info" data-target="info" title="{{ data.l10n.info }}" onclick="prplSuggestedTask.runButtonAction( this );">
32+
<button type="button" class="prpl-suggested-task-button" data-task-id="{{ data.post.meta.prpl_task_id }}" data-task-title="{{ data.post.title.rendered }}" data-action="info" data-target="info" title="{{ data.l10n.info }}">
3333
<img src="{{ data.assets.infoIcon }}" alt="{{ data.l10n.info }}" class="icon">
3434
<span class="screen-reader-text">{{ data.l10n.info }}</span>
3535
</button>
@@ -53,7 +53,7 @@ <h3 style="width: 100%;">
5353
<# if ( data.post.meta.prpl_snoozable ) { #>
5454
<prpl-tooltip class="prpl-suggested-task-snooze">
5555
<slot name="open-icon">
56-
<button type="button" class="prpl-suggested-task-button" data-task-id="{{ data.post.meta.prpl_task_id }}" data-task-title="{{ data.post.title.rendered }}" data-action="snooze" data-target="snooze" title="{{ data.l10n.snooze }}" onclick="prplSuggestedTask.runButtonAction( this );">
56+
<button type="button" class="prpl-suggested-task-button" data-task-id="{{ data.post.meta.prpl_task_id }}" data-task-title="{{ data.post.title.rendered }}" data-action="snooze" data-target="snooze" title="{{ data.l10n.snooze }}">
5757
<img src="{{ data.assets.snoozeIcon }}" alt="{{ data.l10n.snooze }}" class="icon">
5858
<span class="screen-reader-text">{{ data.l10n.snooze }}</span>
5959
</button>

0 commit comments

Comments
 (0)