Merge branch 'develop' into ari/improve-security

ilicfilip · web-flow · commit 091d0631b54f · 2025-10-22T10:24:17.000+02:00
diff --git a/assets/js/recommendations/remove-terms-without-posts.js b/assets/js/recommendations/remove-terms-without-posts.js
@@ -14,6 +14,12 @@
 		 */
 		constructor() {
 			this.popoverId = 'prpl-popover-remove-terms-without-posts';
+
+			// Early return if the popover is not found.
+			if ( ! document.getElementById( this.popoverId ) ) {
+				return;
+			}
+
 			this.currentTermData = null;
 			this.currentTaskElement = null;
 			this.elements = this.getElements();
diff --git a/assets/js/recommendations/update-term-description.js b/assets/js/recommendations/update-term-description.js
@@ -14,6 +14,12 @@
 		 */
 		constructor() {
 			this.popoverId = 'prpl-popover-update-term-description';
+
+			// Early return if the popover is not found.
+			if ( ! document.getElementById( this.popoverId ) ) {
+				return;
+			}
+
 			this.currentTermData = null;
 			this.currentTaskElement = null;
 			this.elements = this.getElements();
diff --git a/classes/suggested-tasks/providers/class-blog-description.php b/classes/suggested-tasks/providers/class-blog-description.php
@@ -45,7 +45,7 @@ class Blog_Description extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_NORMAL - 5;
+	protected $priority = 2;
 
 	/**
 	 * Get the task title.
diff --git a/classes/suggested-tasks/providers/class-content-review.php b/classes/suggested-tasks/providers/class-content-review.php
@@ -56,7 +56,7 @@ class Content_Review extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_LOW;
+	protected $priority = 10;
 
 	/**
 	 * Whether the task is dismissable.
diff --git a/classes/suggested-tasks/providers/class-core-update.php b/classes/suggested-tasks/providers/class-core-update.php
@@ -45,7 +45,7 @@ class Core_Update extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_CRITICAL;
+	protected $priority = 20;
 
 	/**
 	 * Get the task URL.
diff --git a/classes/suggested-tasks/providers/class-debug-display.php b/classes/suggested-tasks/providers/class-debug-display.php
@@ -38,7 +38,7 @@ class Debug_Display extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_CRITICAL + 5;
+	protected $priority = 10;
 
 	/**
 	 * Get the task title.
diff --git a/classes/suggested-tasks/providers/class-disable-comment-pagination.php b/classes/suggested-tasks/providers/class-disable-comment-pagination.php
@@ -40,6 +40,13 @@ class Disable_Comment_Pagination extends Tasks_Interactive {
 	 */
 	protected const EXTERNAL_LINK_URL = 'https://prpl.fyi/disable-comment-pagination';
 
+	/**
+	 * The task priority.
+	 *
+	 * @var int
+	 */
+	protected $priority = 10;
+
 	/**
 	 * Get the task URL.
 	 *
diff --git a/classes/suggested-tasks/providers/class-disable-comments.php b/classes/suggested-tasks/providers/class-disable-comments.php
@@ -40,6 +40,13 @@ class Disable_Comments extends Tasks_Interactive {
 	 */
 	protected const EXTERNAL_LINK_URL = 'https://prpl.fyi/disable-comments';
 
+	/**
+	 * The task priority.
+	 *
+	 * @var int
+	 */
+	protected $priority = 9;
+
 	/**
 	 * Get the task URL.
 	 *
diff --git a/classes/suggested-tasks/providers/class-email-sending.php b/classes/suggested-tasks/providers/class-email-sending.php
@@ -52,7 +52,7 @@ class Email_Sending extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_URGENT + 1;
+	protected $priority = 4;
 
 	/**
 	 * The email title.
diff --git a/classes/suggested-tasks/providers/class-fewer-tags.php b/classes/suggested-tasks/providers/class-fewer-tags.php
@@ -49,7 +49,7 @@ class Fewer_Tags extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_HIGH + 12;
+	protected $priority = 32;
 
 	/**
 	 * The plugin active state.
diff --git a/classes/suggested-tasks/providers/class-hello-world.php b/classes/suggested-tasks/providers/class-hello-world.php
@@ -56,6 +56,13 @@ class Hello_World extends Tasks_Interactive {
 	 */
 	protected const EXTERNAL_LINK_URL = 'https://prpl.fyi/delete-hello-world-post';
 
+	/**
+	 * The task priority.
+	 *
+	 * @var int
+	 */
+	protected $priority = 15;
+
 	/**
 	 * Get the task URL.
 	 *
diff --git a/classes/suggested-tasks/providers/class-permalink-structure.php b/classes/suggested-tasks/providers/class-permalink-structure.php
@@ -45,7 +45,7 @@ class Permalink_Structure extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_HIGH;
+	protected $priority = 3;
 
 	/**
 	 * Initialize the task.
diff --git a/classes/suggested-tasks/providers/class-php-version.php b/classes/suggested-tasks/providers/class-php-version.php
@@ -45,7 +45,7 @@ class Php_Version extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_URGENT + 3;
+	protected $priority = 25;
 
 	/**
 	 * Get the title.
diff --git a/classes/suggested-tasks/providers/class-remove-inactive-plugins.php b/classes/suggested-tasks/providers/class-remove-inactive-plugins.php
@@ -42,6 +42,13 @@ class Remove_Inactive_Plugins extends Tasks {
 	 */
 	protected const EXTERNAL_LINK_URL = 'https://prpl.fyi/remove-inactive-plugins';
 
+	/**
+	 * The task priority.
+	 *
+	 * @var int
+	 */
+	protected $priority = 60;
+
 	/**
 	 * Get the task URL.
 	 *
diff --git a/classes/suggested-tasks/providers/class-remove-terms-without-posts.php b/classes/suggested-tasks/providers/class-remove-terms-without-posts.php
@@ -62,7 +62,7 @@ class Remove_Terms_Without_Posts extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_LOW;
+	protected $priority = 60;
 
 	/**
 	 * The minimum number of posts.
diff --git a/classes/suggested-tasks/providers/class-rename-uncategorized-category.php b/classes/suggested-tasks/providers/class-rename-uncategorized-category.php
@@ -56,6 +56,13 @@ class Rename_Uncategorized_Category extends Tasks_Interactive {
 	 */
 	protected const EXTERNAL_LINK_URL = 'https://prpl.fyi/rename-uncategorized-category';
 
+	/**
+	 * The task priority.
+	 *
+	 * @var int
+	 */
+	protected $priority = 60;
+
 	/**
 	 * Initialize the task.
 	 *
diff --git a/classes/suggested-tasks/providers/class-sample-page.php b/classes/suggested-tasks/providers/class-sample-page.php
@@ -56,6 +56,13 @@ class Sample_Page extends Tasks_Interactive {
 	 */
 	protected const EXTERNAL_LINK_URL = 'https://prpl.fyi/delete-sample-page';
 
+	/**
+	 * The task priority.
+	 *
+	 * @var int
+	 */
+	protected $priority = 14;
+
 	/**
 	 * Get the task URL.
 	 *
diff --git a/classes/suggested-tasks/providers/class-search-engine-visibility.php b/classes/suggested-tasks/providers/class-search-engine-visibility.php
@@ -45,7 +45,7 @@ class Search_Engine_Visibility extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_URGENT + 2;
+	protected $priority = 5;
 
 	/**
 	 * Initialize the task.
diff --git a/classes/suggested-tasks/providers/class-select-locale.php b/classes/suggested-tasks/providers/class-select-locale.php
@@ -59,7 +59,7 @@ class Select_Locale extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_NORMAL - 4;
+	protected $priority = 8;
 
 	/**
 	 * Initialize the task.
diff --git a/classes/suggested-tasks/providers/class-select-timezone.php b/classes/suggested-tasks/providers/class-select-timezone.php
@@ -45,7 +45,7 @@ class Select_Timezone extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_NORMAL - 4;
+	protected $priority = 6;
 
 	/**
 	 * Initialize the task.
diff --git a/classes/suggested-tasks/providers/class-seo-plugin.php b/classes/suggested-tasks/providers/class-seo-plugin.php
@@ -54,7 +54,7 @@ class SEO_Plugin extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_HIGH;
+	protected $priority = 20;
 
 	/**
 	 * Get the task URL.
diff --git a/classes/suggested-tasks/providers/class-set-date-format.php b/classes/suggested-tasks/providers/class-set-date-format.php
@@ -38,7 +38,7 @@ class Set_Date_Format extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_NORMAL - 4;
+	protected $priority = 7;
 
 	/**
 	 * Initialize the task.
diff --git a/classes/suggested-tasks/providers/class-set-valuable-post-types.php b/classes/suggested-tasks/providers/class-set-valuable-post-types.php
@@ -38,7 +38,7 @@ class Set_Valuable_Post_Types extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_LOW + 10;
+	protected $priority = 70;
 
 	/**
 	 * Get the task URL.
diff --git a/classes/suggested-tasks/providers/class-settings-saved.php b/classes/suggested-tasks/providers/class-settings-saved.php
@@ -24,7 +24,7 @@ class Settings_Saved extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_URGENT;
+	protected $priority = 10;
 
 	/**
 	 * Whether the task is an onboarding task.
diff --git a/classes/suggested-tasks/providers/class-site-icon.php b/classes/suggested-tasks/providers/class-site-icon.php
@@ -45,7 +45,7 @@ class Site_Icon extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_NORMAL - 5;
+	protected $priority = 1;
 
 	/**
 	 * Get the link setting.
diff --git a/classes/suggested-tasks/providers/class-tasks.php b/classes/suggested-tasks/providers/class-tasks.php
@@ -66,36 +66,6 @@ abstract class Tasks implements Tasks_Interface {
 	 */
 	protected const POPOVER_ID = '';
 
-	/**
-	 * Priority constants for task ordering.
-	 *
-	 * Tasks are ordered from lowest to highest priority value (0 = highest priority, 100 = lowest priority).
-	 *
-	 * CRITICAL (0-9): System-critical issues that must be addressed immediately
-	 * - Examples: Core updates, security vulnerabilities, public error display
-	 *
-	 * URGENT (10-19): Important for security, SEO, or core functionality
-	 * - Examples: Search engine visibility, email functionality, PHP version, initial settings
-	 *
-	 * HIGH (20-39): Important for site quality and SEO
-	 * - Examples: Permalink structure, content optimization
-	 *
-	 * NORMAL (40-59): Standard site configuration and cleanup
-	 * - Examples: Branding (tagline, site icon), default content cleanup, regular content creation
-	 *
-	 * LOW (60-79): Nice-to-have improvements
-	 * - Examples: Content review, content organization, configuration refinements
-	 *
-	 * OPTIONAL (80-100): Advanced optimization and enhancement features
-	 * - Examples: Term descriptions, advanced SEO features
-	 */
-	protected const PRIORITY_CRITICAL = 0;
-	protected const PRIORITY_URGENT   = 10;
-	protected const PRIORITY_HIGH     = 20;
-	protected const PRIORITY_NORMAL   = 50;
-	protected const PRIORITY_LOW      = 60;
-	protected const PRIORITY_OPTIONAL = 80;
-
 	/**
 	 * Whether the task is repetitive.
 	 *
@@ -125,7 +95,7 @@ abstract class Tasks implements Tasks_Interface {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_NORMAL;
+	protected $priority = 50;
 
 	/**
 	 * Whether the task is dismissable.
diff --git a/classes/suggested-tasks/providers/class-unpublished-content.php b/classes/suggested-tasks/providers/class-unpublished-content.php
@@ -56,7 +56,7 @@ class Unpublished_Content extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_HIGH + 10;
+	protected $priority = 55;
 
 	/**
 	 * Whether the task is dismissable.
diff --git a/classes/suggested-tasks/providers/class-update-term-description.php b/classes/suggested-tasks/providers/class-update-term-description.php
@@ -76,7 +76,7 @@ class Update_Term_Description extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_OPTIONAL;
+	protected $priority = 80;
 
 	/**
 	 * The completed term IDs.
diff --git a/classes/suggested-tasks/providers/integrations/aioseo/class-aioseo-interactive-provider.php b/classes/suggested-tasks/providers/integrations/aioseo/class-aioseo-interactive-provider.php
@@ -26,5 +26,5 @@ abstract class AIOSEO_Interactive_Provider extends Tasks_Interactive {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_NORMAL;
+	protected $priority = 20;
 }
diff --git a/classes/suggested-tasks/providers/integrations/aioseo/class-aioseo-provider.php b/classes/suggested-tasks/providers/integrations/aioseo/class-aioseo-provider.php
@@ -26,5 +26,5 @@ abstract class AIOSEO_Provider extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_NORMAL;
+	protected $priority = 20;
 }
diff --git a/classes/suggested-tasks/providers/integrations/yoast/class-cornerstone-workout.php b/classes/suggested-tasks/providers/integrations/yoast/class-cornerstone-workout.php
@@ -42,7 +42,7 @@ class Cornerstone_Workout extends Yoast_Provider {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_HIGH;
+	protected $priority = 20;
 
 	/**
 	 * Whether the task is dismissable.
diff --git a/classes/suggested-tasks/providers/integrations/yoast/class-orphaned-content-workout.php b/classes/suggested-tasks/providers/integrations/yoast/class-orphaned-content-workout.php
@@ -42,7 +42,7 @@ class Orphaned_Content_Workout extends Yoast_Provider {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_HIGH;
+	protected $priority = 20;
 
 	/**
 	 * Whether the task is dismissable.
diff --git a/classes/suggested-tasks/providers/integrations/yoast/class-yoast-provider.php b/classes/suggested-tasks/providers/integrations/yoast/class-yoast-provider.php
@@ -26,7 +26,7 @@ abstract class Yoast_Provider extends Tasks {
 	 *
 	 * @var int
 	 */
-	protected $priority = self::PRIORITY_HIGH;
+	protected $priority = 20;
 
 	/**
 	 * Get the focus tasks.
diff --git a/classes/update/class-update-190.php b/classes/update/class-update-190.php
diff --git a/tests/phpunit/test-class-upgrade-migration-190.php b/tests/phpunit/test-class-upgrade-migration-190.php

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ class Blog_Description extends Tasks_Interactive {`
`45`	`45`	`*`
`46`	`46`	`* @var int`
`47`	`47`	`*/`
`48`		`- protected $priority = self::PRIORITY_NORMAL - 5;`
	`48`	`+ protected $priority = 2;`
`49`	`49`
`50`	`50`	`/**`
`51`	`51`	`* Get the task title.`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ class Content_Review extends Tasks {`
`56`	`56`	`*`
`57`	`57`	`* @var int`
`58`	`58`	`*/`
`59`		`- protected $priority = self::PRIORITY_LOW;`
	`59`	`+ protected $priority = 10;`
`60`	`60`
`61`	`61`	`/**`
`62`	`62`	`* Whether the task is dismissable.`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ class Core_Update extends Tasks {`
`45`	`45`	`*`
`46`	`46`	`* @var int`
`47`	`47`	`*/`
`48`		`- protected $priority = self::PRIORITY_CRITICAL;`
	`48`	`+ protected $priority = 20;`
`49`	`49`
`50`	`50`	`/**`
`51`	`51`	`* Get the task URL.`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ class Debug_Display extends Tasks {`
`38`	`38`	`*`
`39`	`39`	`* @var int`
`40`	`40`	`*/`
`41`		`- protected $priority = self::PRIORITY_CRITICAL + 5;`
	`41`	`+ protected $priority = 10;`
`42`	`42`
`43`	`43`	`/**`
`44`	`44`	`* Get the task title.`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ class Email_Sending extends Tasks_Interactive {`
`52`	`52`	`*`
`53`	`53`	`* @var int`
`54`	`54`	`*/`
`55`		`- protected $priority = self::PRIORITY_URGENT + 1;`
	`55`	`+ protected $priority = 4;`
`56`	`56`
`57`	`57`	`/**`
`58`	`58`	`* The email title.`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ class Fewer_Tags extends Tasks_Interactive {`
`49`	`49`	`*`
`50`	`50`	`* @var int`
`51`	`51`	`*/`
`52`		`- protected $priority = self::PRIORITY_HIGH + 12;`
	`52`	`+ protected $priority = 32;`
`53`	`53`
`54`	`54`	`/**`
`55`	`55`	`* The plugin active state.`