Merge pull request #414 from ProgressPlanner/filip/author-feed-tweak

Yoast SEO tasks tweaks

Author: jdevalk

classes/suggested-tasks/local-tasks/providers/integrations/yoast/class-add-yoast-providers.php

@@ -45,10 +45,14 @@ public function enqueue_assets( $hook ) {
 		$focus_tasks = [];
 
 		foreach ( $this->providers as $provider ) {
-			$focus_task = $provider->get_focus_tasks();
 
-			if ( $focus_task ) {
-				$focus_tasks[] = $focus_task;
+			// Add Ravi icon if the task is pending or completed.
+			if ( $provider->should_add_task() ) {
+				$focus_task = $provider->get_focus_tasks();
+
+				if ( $focus_task ) {
+					$focus_tasks[] = $focus_task;
+				}
 			}
 		}
 

classes/suggested-tasks/local-tasks/providers/integrations/yoast/class-crawl-settings-feed-authors.php

@@ -7,23 +7,40 @@
 
 namespace Progress_Planner\Suggested_Tasks\Local_Tasks\Providers\Integrations\Yoast;
 
+use Progress_Planner\Suggested_Tasks\Data_Collector\Post_Author;
+
 /**
  * Add task for Yoast SEO: Remove post authors feeds.
  */
 class Crawl_Settings_Feed_Authors extends Yoast_Provider {
 
+	/**
+	 * The minimum number of posts with a post format to add the task.
+	 *
+	 * @var int
+	 */
+	protected const MINIMUM_AUTHOR_WITH_POSTS = 1;
+
 	/**
 	 * The provider ID.
 	 *
 	 * @var string
 	 */
 	protected const PROVIDER_ID = 'yoast-crawl-settings-feed-authors';
 
+	/**
+	 * The data collector.
+	 *
+	 * @var \Progress_Planner\Suggested_Tasks\Data_Collector\Post_Author
+	 */
+	protected $data_collector;
+
 	/**
 	 * Constructor.
 	 */
 	public function __construct() {
-		$this->url = \admin_url( 'admin.php?page=wpseo_page_settings#/crawl-optimization#input-wpseo-remove_feed_authors' );
+		$this->data_collector = new Post_Author();
+		$this->url            = \admin_url( 'admin.php?page=wpseo_page_settings#/crawl-optimization#input-wpseo-remove_feed_authors' );
 	}
 
 	/**
@@ -71,6 +88,11 @@ public function get_focus_tasks() {
 	 * @return bool
 	 */
 	public function should_add_task() {
+		// If there is more than one author, we don't need to add the task.
+		if ( $this->data_collector->collect() > self::MINIMUM_AUTHOR_WITH_POSTS ) {
+			return false;
+		}
+
 		$yoast_options = \WPSEO_Options::get_instance()->get_all();
 		foreach ( [ 'remove_feed_authors' ] as $option ) {
 			// If the crawl settings are already optimized, we don't need to add the task.