Merge pull request #278 from ProgressPlanner/filip/add-onboard-for-existing-users

Handle upgrading for existing users & add new tasks to the list

Author: aristath

classes/class-plugin-upgrade-handler.php

@@ -54,9 +54,23 @@ public function get_newly_added_task_provider_ids() {
 
 		if ( null === $newly_added_task_providers ) {
 
-			// Check if task providers option exists, it will not on fresh installs.
+			// Privacy policy is not accepted, so it's a fresh install.
+			$fresh_install = ! \progress_planner()->is_privacy_policy_accepted();
+
+			// Check if task providers option exists, it will not on fresh installs and v1.0.4 and older.
 			$old_task_providers = \get_option( 'progress_planner_previous_version_task_providers', [] );
 
+			// We're upgrading from v1.0.4 and older, set the old task providers to what we had before the upgrade.
+			if ( ! $fresh_install && empty( $old_task_providers ) ) {
+				$old_task_providers = [
+					'core-blogdescription',
+					'wp-debug-display',
+					'sample-page',
+					'hello-world',
+					'core-siteicon',
+				];
+			}
+
 			$newly_added_task_providers = [];
 
 			foreach ( $this->onboard_task_provider_ids as $task_provider_id ) {

classes/suggested-tasks/local-tasks/providers/one-time/class-permalink-structure.php

@@ -26,6 +26,12 @@ class Permalink_Structure extends One_Time {
 	 */
 	const ID = 'core-permalink-structure';
 
+	/**
+	 * Whether the task is an onboarding task.
+	 *
+	 * @var bool
+	 */
+	protected $is_onboarding_task = true;
 
 	/**
 	 * Check if the task condition is satisfied.

classes/suggested-tasks/local-tasks/providers/one-time/class-rename-uncategorized-category.php

@@ -33,6 +33,13 @@ class Rename_Uncategorized_Category extends One_Time {
 	 */
 	protected $capability = 'manage_categories';
 
+	/**
+	 * Whether the task is an onboarding task.
+	 *
+	 * @var bool
+	 */
+	protected $is_onboarding_task = true;
+
 	/**
 	 * The Uncategorized category.
 	 *

classes/suggested-tasks/local-tasks/providers/one-time/class-search-engine-visibility.php

@@ -26,6 +26,13 @@ class Search_Engine_Visibility extends One_Time {
 	 */
 	const ID = 'search-engine-visibility';
 
+	/**
+	 * Whether the task is an onboarding task.
+	 *
+	 * @var bool
+	 */
+	protected $is_onboarding_task = true;
+
 	/**
 	 * Check if the task should be added.
 	 *