Merge pull request #669 from ProgressPlanner/filip/v19/yoast-site-logo-fallback

Detect site logo as fallback, for "Yoast SEO: set your organization logo" task

Author: aristath

classes/suggested-tasks/providers/integrations/yoast/class-organization-logo.php

@@ -98,6 +98,18 @@ public function get_focus_tasks() {
 	 * @return bool
 	 */
 	public function should_add_task() {
+
+		// Check if the site logo is set, Yoast SEO uses it as a fallback.
+		$site_logo_id = \get_option( 'site_logo' );
+		if ( ! $site_logo_id ) {
+			$site_logo_id = \get_theme_mod( 'custom_logo', false );
+		}
+
+		// If the site logo is set, we don't need to add the task.
+		if ( (int) $site_logo_id ) {
+			return false;
+		}
+
 		// If the site is for a person, and the person logo is already set, we don't need to add the task.
 		if ( $this->yoast_seo->helpers->options->get( 'company_or_person', 'company' ) === 'company' // @phpstan-ignore-line property.nonObject
 			&& $this->yoast_seo->helpers->options->get( 'company_logo' ) // @phpstan-ignore-line property.nonObject

readme.txt

@@ -83,6 +83,12 @@ https://youtu.be/e1bmxZYyXFY
 
 == Changelog ==
 
+= 1.9.0 =
+
+Enhancements:
+
+* "Yoast SEO: set your organization logo" task detects site logo as fallback, same as Yoast SEO does.
+
 = 1.8.1 =
 
 - Security fix: Privilege escalation via an AJAX call where authenticated users could update arbitrary site options.