Skip to content

Commit 24ea49c

Browse files
committed
smarter
1 parent 55ccea0 commit 24ea49c

1 file changed

Lines changed: 15 additions & 22 deletions

File tree

assets/js/web-components/prpl-chart-line.js

Lines changed: 15 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -181,28 +181,21 @@ customElements.define(
181181
getYLabelsStepsDivider = () => {
182182
const maxValuePadded = this.getMaxValuePadded();
183183

184-
const steps3Remainder = maxValuePadded % 3;
185-
const steps4Remainder = maxValuePadded % 4;
186-
const steps5Remainder = maxValuePadded % 5;
187-
188-
if ( steps4Remainder === 0 ) {
189-
return 4;
190-
} else if ( steps3Remainder === 0 ) {
191-
return 3;
192-
} else if ( steps5Remainder === 0 ) {
193-
return 5;
194-
} else if (
195-
steps3Remainder < steps4Remainder &&
196-
steps3Remainder < steps5Remainder
197-
) {
198-
return 3;
199-
} else if (
200-
steps5Remainder < steps3Remainder &&
201-
steps5Remainder < steps4Remainder
202-
) {
203-
return 5;
204-
}
205-
return 4;
184+
const stepsRemainders = {
185+
4: maxValuePadded % 4,
186+
5: maxValuePadded % 5,
187+
3: maxValuePadded % 3,
188+
};
189+
// Get the smallest remainder.
190+
const smallestRemainder = Math.min(
191+
...Object.values( stepsRemainders )
192+
);
193+
194+
// Get the key of the smallest remainder.
195+
const smallestRemainderKey = Object.keys( stepsRemainders ).find(
196+
( key ) => stepsRemainders[ key ] === smallestRemainder
197+
);
198+
return smallestRemainderKey;
206199
};
207200

208201
/**

0 commit comments

Comments
 (0)