Revert "check for activities"

This reverts commit 99d6290.

Author: ilicfilip

classes/class-suggested-tasks.php

@@ -177,21 +177,7 @@ public function get_tasks_manager(): Tasks_Manager {
 	 */
 	public function was_task_completed( $task_id ): bool {
 		$task = \progress_planner()->get_suggested_tasks_db()->get_post( $task_id );
-
-		// Checks for task (post) status, trash or pending.
-		if ( $task && $task->is_completed() ) {
-			return true;
-		}
-
-		// Checks for activity, if there is an activity for the task, it means that the task was completed (and post might already be deleted from the trash).
-		$activity = \progress_planner()->get_activities__query()->query_activities(
-			[
-				'category' => 'suggested_task',
-				'data_id'  => $task_id,
-			]
-		);
-
-		return ! empty( $activity );
+		return $task && $task->is_completed();
 	}
 
 	/**

classes/suggested-tasks/providers/class-select-locale.php

@@ -173,14 +173,14 @@ function ( $locale ) {
 	 * @return bool
 	 */
 	public function is_task_completed( $task_id = '' ) {
-		$activity = \progress_planner()->get_activities__query()->query_activities(
+		$locale_activity = \progress_planner()->get_activities__query()->query_activities(
 			[
 				'category' => 'suggested_task',
 				'data_id'  => static::PROVIDER_ID,
 			]
 		);
 
-		return ! empty( $activity );
+		return ! empty( $locale_activity );
 	}
 
 	/**

classes/suggested-tasks/providers/class-select-timezone.php

@@ -85,14 +85,14 @@ protected function get_title() {
 	 * @return bool
 	 */
 	public function should_add_task() {
-		$activity = \progress_planner()->get_activities__query()->query_activities(
+		$timezone_activity = \progress_planner()->get_activities__query()->query_activities(
 			[
 				'category' => 'suggested_task',
 				'data_id'  => static::PROVIDER_ID,
 			]
 		);
 
-		return ! $activity;
+		return ! $timezone_activity;
 	}
 
 	/**