Merge branch 'develop' into filip/v19/adjust-terms-task-description

Author: ilicfilip

classes/suggested-tasks/providers/class-improve-pdf-handling.php

@@ -92,7 +92,7 @@ public function should_add_task() {
 				[
 					'post_type'      => 'attachment',
 					'post_mime_type' => 'application/pdf',
-					'post_status'    => 'publish',
+					'post_status'    => 'inherit',
 					'posts_per_page' => static::MIN_PDF_FILES + 1, // We want to get at least 11 PDF files to be sure we have enough.
 					'fields'         => 'ids',
 				]
@@ -101,7 +101,7 @@ public function should_add_task() {
 			\progress_planner()->get_utils__cache()->set( 'pdf_files_count', $pdf_files_count, DAY_IN_SECONDS );
 		}
 
-		return static::MIN_PDF_FILES < $pdf_files_count;
+		return static::MIN_PDF_FILES < (int) $pdf_files_count;
 	}
 
 	/**

classes/suggested-tasks/providers/class-remove-terms-without-posts.php

@@ -115,6 +115,14 @@ public function init() {
 	 * @return void
 	 */
 	public function maybe_remove_irrelevant_tasks( $object_id, $terms, $tt_ids, $taxonomy, $append, $old_tt_ids ) {
+
+		$taxonomy_object = \get_taxonomy( $taxonomy );
+
+		// Check if the taxonomy is public, we are not interested in non-public taxonomies (also our data collector doesn't track non-public taxonomies).
+		if ( ! $taxonomy_object || ! $taxonomy_object->public ) {
+			return;
+		}
+
 		foreach ( \progress_planner()->get_suggested_tasks_db()->get_tasks_by( [ 'provider_id' => $this->get_provider_id() ] ) as $task ) {
 			/**
 			 * The task post object.

classes/suggested-tasks/providers/class-update-term-description.php

@@ -107,6 +107,14 @@ public function init() {
 	 * @return void
 	 */
 	public function maybe_remove_irrelevant_tasks( $term, $tt_id, $taxonomy, $deleted_term, $object_ids ) {
+
+		$taxonomy_object = \get_taxonomy( $taxonomy );
+
+		// Check if the taxonomy is public, we are not interested in non-public taxonomies (also our data collector doesn't track non-public taxonomies).
+		if ( ! $taxonomy_object || ! $taxonomy_object->public ) {
+			return;
+		}
+
 		$pending_tasks = \progress_planner()->get_suggested_tasks_db()->get_tasks_by( [ 'provider_id' => $this->get_provider_id() ] );
 
 		if ( ! $pending_tasks ) {