Skip to content

Commit 5403b02

Browse files
committed
missed gauge badge
1 parent 81de1e5 commit 5403b02

4 files changed

Lines changed: 8 additions & 2 deletions

File tree

assets/js/web-components/prpl-badge.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ customElements.define(
1919

2020
badgeId = badgeId || this.getAttribute( 'badge-id' );
2121
badgeName = badgeName || this.getAttribute( 'badge-name' );
22-
badgeName = badgeName || `${ prplL10n( 'badge' ) }`;
22+
23+
if ( ! badgeName || 'null' === badgeName ) {
24+
badgeName = `${ prplL10n( 'badge' ) }`;
25+
}
2326

2427
this.innerHTML = `
2528
<img

assets/js/web-components/prpl-gauge.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ const prplUpdateRaviGauge = ( pointsDiff ) => {
104104
max: gaugeElement.getAttribute( 'data-max' ),
105105
value: gaugeElement.getAttribute( 'data-value' ),
106106
badgeId: gaugeElement.getAttribute( 'data-badge-id' ),
107+
badgeName: gaugeElement.getAttribute( 'data-badge-name' ),
107108
};
108109

109110
if ( ! gaugeProps ) {
@@ -130,7 +131,7 @@ const prplUpdateRaviGauge = ( pointsDiff ) => {
130131
'var(--prpl-padding) var(--prpl-padding) calc(var(--prpl-padding) * 2) var(--prpl-padding)',
131132
marginBottom: 'var(--prpl-padding)',
132133
},
133-
`<prpl-badge complete="true" badge-id="${ gaugeProps.badgeId }"></prpl-badge>`
134+
`<prpl-badge complete="true" badge-id="${ gaugeProps.badgeId }" badge-name="${ gaugeProps.badgeName }"></prpl-badge>`
134135
);
135136
gauge.id = gaugeProps.id;
136137
gauge.setAttribute( 'background', gaugeProps.background );

views/dashboard-widgets/score.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
data-max="<?php echo (int) Monthly::TARGET_POINTS; ?>"
2222
data-value="<?php echo (float) \progress_planner()->get_admin__widgets__monthly_badges()->get_score()['target_score']; ?>"
2323
data-badge-id="<?php echo \esc_attr( $prpl_badge->get_id() ); ?>"
24+
data-badge-name="<?php echo \esc_attr( $prpl_badge->get_name() ); ?>"
2425
>
2526
<progress max="<?php echo (int) Monthly::TARGET_POINTS; ?>" value="<?php echo (float) \progress_planner()->get_admin__widgets__monthly_badges()->get_score()['target_score']; ?>">
2627
<prpl-badge

views/page-widgets/monthly-badges.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
data-max="<?php echo (int) Monthly::TARGET_POINTS; ?>"
2828
data-value="<?php echo (float) $prpl_widget->get_score()['target_score']; ?>"
2929
data-badge-id="<?php echo \esc_attr( $prpl_badge->get_id() ); ?>"
30+
data-badge-name="<?php echo \esc_attr( $prpl_badge->get_name() ); ?>"
3031
>
3132
<progress max="<?php echo (int) Monthly::TARGET_POINTS; ?>" value="<?php echo (float) $prpl_widget->get_score()['target_score']; ?>">
3233
<prpl-badge complete="true" badge-id="<?php echo \esc_attr( $prpl_badge->get_id() ); ?>" badge-name="<?php echo \esc_attr( $prpl_badge->get_name() ); ?>"></prpl-badge>

0 commit comments

Comments
 (0)