Fix risky tests

Author: aristath

tests/phpunit/traits/test-class-ajax-security-aioseo.php

@@ -69,11 +69,18 @@ public function test_verify_aioseo_active_or_fail_not_active() {
 		// Verify aioseo function doesn't exist.
 		$this->assertFalse( \function_exists( 'aioseo' ) );
 
+		// WordPress Core's _handleAjax() starts output buffering before calling AJAX actions.
+		// We need to do the same since we're calling methods directly.
+		// WordPress Core's dieHandler() will call ob_get_clean() to clean this buffer.
+		\ini_set( 'implicit_flush', false );
+		\ob_start();
+
 		// WP_Ajax_UnitTestCase allows us to test AJAX methods that call wp_send_json_error().
 		try {
 			$this->mock_class->public_verify_aioseo_active_or_fail();
 			$this->fail( 'Expected WPAjaxDieContinueException was not thrown' );
 		} catch ( \WPAjaxDieContinueException $e ) {
+			// WordPress Core's dieHandler() calls ob_get_clean() which gets output and cleans buffer.
 			// Get the response.
 			$response = json_decode( $this->_last_response, true );
 			$this->assertFalse( $response['success'] );

tests/phpunit/traits/test-class-ajax-security-base.php

@@ -102,11 +102,18 @@ public function test_verify_nonce_or_fail_valid() {
 	public function test_verify_nonce_or_fail_invalid() {
 		$_REQUEST['nonce'] = 'invalid_nonce';
 
+		// WordPress Core's _handleAjax() starts output buffering before calling AJAX actions.
+		// We need to do the same since we're calling methods directly.
+		// WordPress Core's dieHandler() will call ob_get_clean() to clean this buffer.
+		\ini_set( 'implicit_flush', false );
+		\ob_start();
+
 		// WP_Ajax_UnitTestCase allows us to test AJAX methods that call wp_send_json_error().
 		try {
 			$this->mock_class->public_verify_nonce_or_fail();
 			$this->fail( 'Expected WPAjaxDieContinueException was not thrown' );
 		} catch ( \WPAjaxDieContinueException $e ) {
+			// WordPress Core's dieHandler() calls ob_get_clean() which gets output and cleans buffer.
 			// Get the response.
 			$response = json_decode( $this->_last_response, true );
 			$this->assertFalse( $response['success'] );
@@ -148,11 +155,18 @@ public function test_verify_capability_or_fail_non_admin() {
 		$user_id = $this->factory->user->create( [ 'role' => 'subscriber' ] );
 		\wp_set_current_user( $user_id );
 
+		// WordPress Core's _handleAjax() starts output buffering before calling AJAX actions.
+		// We need to do the same since we're calling methods directly.
+		// WordPress Core's dieHandler() will call ob_get_clean() to clean this buffer.
+		\ini_set( 'implicit_flush', false );
+		\ob_start();
+
 		// WP_Ajax_UnitTestCase allows us to test AJAX methods that call wp_send_json_error().
 		try {
 			$this->mock_class->public_verify_capability_or_fail();
 			$this->fail( 'Expected WPAjaxDieContinueException was not thrown' );
 		} catch ( \WPAjaxDieContinueException $e ) {
+			// WordPress Core's dieHandler() calls ob_get_clean() which gets output and cleans buffer.
 			// Get the response.
 			$response = json_decode( $this->_last_response, true );
 			$this->assertFalse( $response['success'] );

tests/phpunit/traits/test-class-ajax-security-yoast.php

@@ -69,11 +69,18 @@ public function test_verify_yoast_active_or_fail_not_active() {
 		// Verify WPSEO_Options class doesn't exist.
 		$this->assertFalse( \class_exists( 'WPSEO_Options' ) );
 
+		// WordPress Core's _handleAjax() starts output buffering before calling AJAX actions.
+		// We need to do the same since we're calling methods directly.
+		// WordPress Core's dieHandler() will call ob_get_clean() to clean this buffer.
+		\ini_set( 'implicit_flush', false );
+		\ob_start();
+
 		// WP_Ajax_UnitTestCase allows us to test AJAX methods that call wp_send_json_error().
 		try {
 			$this->mock_class->public_verify_yoast_active_or_fail();
 			$this->fail( 'Expected WPAjaxDieContinueException was not thrown' );
 		} catch ( \WPAjaxDieContinueException $e ) {
+			// WordPress Core's dieHandler() calls ob_get_clean() which gets output and cleans buffer.
 			// Get the response.
 			$response = json_decode( $this->_last_response, true );
 			$this->assertFalse( $response['success'] );