Skip to content

Commit 7dec70a

Browse files
authored
Merge branch 'develop' into filip/fix-delete-sample-page-interactive
2 parents efdafa4 + 0d5e642 commit 7dec70a

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Bugs we fixed:
99
* Exclude taxonomies which are marked as not indexable in Yoast SEO
1010
* Improve completed task check for "Unpublished content" task
1111
* Fix "Delete the 'Sample Page' page" interactive task
12+
* Remove 3rd party plugin tasks if they are deactivated.
1213

1314
= 1.7.0 =
1415

classes/suggested-tasks/class-tasks-manager.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -254,14 +254,10 @@ public function evaluate_task( Task $task ) {
254254
return false;
255255
}
256256
$task_provider = $this->get_task_provider( $task->provider->slug );
257-
if ( ! $task_provider ) {
258-
return false;
259-
}
260-
261-
// Check if the task is no longer relevant.
262-
if ( ! $task_provider->is_task_relevant() ) {
257+
if ( ! $task_provider || ! $task_provider->is_task_relevant() ) {
263258
// Remove the task from the published tasks.
264259
\progress_planner()->get_suggested_tasks_db()->delete_recommendation( $task->ID );
260+
return false;
265261
}
266262

267263
return $task_provider->evaluate_task( $task->task_id );

readme.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ Bugs we fixed:
121121
* Exclude taxonomies which are marked as not indexable in Yoast SEO
122122
* Improve completed task check for "Unpublished content" task
123123
* Fix "Delete the 'Sample Page' page" interactive task
124+
* Remove 3rd party plugin tasks if they are deactivated.
124125

125126
= 1.7.0 =
126127

0 commit comments

Comments
 (0)