check for activities

Author: ilicfilip

classes/class-suggested-tasks.php

@@ -177,7 +177,21 @@ public function get_tasks_manager(): Tasks_Manager {
 	 */
 	public function was_task_completed( $task_id ): bool {
 		$task = \progress_planner()->get_suggested_tasks_db()->get_post( $task_id );
-		return $task && $task->is_completed();
+
+		// Checks for task (post) status, trash or pending.
+		if ( $task && $task->is_completed() ) {
+			return true;
+		}
+
+		// Checks for activity, if there is an activity for the task, it means that the task was completed (and post might already be deleted from the trash).
+		$activity = \progress_planner()->get_activities__query()->query_activities(
+			[
+				'category' => 'suggested_task',
+				'data_id'  => $task_id,
+			]
+		);
+
+		return ! empty( $activity );
 	}
 
 	/**

classes/suggested-tasks/providers/class-select-locale.php

@@ -175,14 +175,14 @@ function ( $locale ) {
 	 * @return bool
 	 */
 	public function is_task_completed( $task_id = '' ) {
-		$locale_activity = \progress_planner()->get_activities__query()->query_activities(
+		$activity = \progress_planner()->get_activities__query()->query_activities(
 			[
 				'category' => 'suggested_task',
 				'data_id'  => static::PROVIDER_ID,
 			]
 		);
 
-		return ! empty( $locale_activity );
+		return ! empty( $activity );
 	}
 
 	/**

classes/suggested-tasks/providers/class-select-timezone.php

@@ -87,14 +87,14 @@ protected function get_description() {
 	 * @return bool
 	 */
 	public function should_add_task() {
-		$timezone_activity = \progress_planner()->get_activities__query()->query_activities(
+		$activity = \progress_planner()->get_activities__query()->query_activities(
 			[
 				'category' => 'suggested_task',
 				'data_id'  => static::PROVIDER_ID,
 			]
 		);
 
-		return ! $timezone_activity;
+		return ! $activity;
 	}
 
 	/**