add more phpcs rules

Author: aristath

phpcs.xml.dist

@@ -124,6 +124,33 @@
 	<!-- Enforce short arrays: -->
 	<rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
 
+	<!-- Other rules -->
+	<rule ref="Universal.Files.SeparateFunctionsFromOO"/>
+	<rule ref="Universal.FunctionDeclarations.RequireFinalMethodsInTraits"/>
+	<rule ref="Modernize.FunctionCalls.Dirname"/>
+	<rule ref="NormalizedArrays.Arrays.ArrayBraceSpacing"/>
+	<rule ref="NormalizedArrays.Arrays.CommaAfterLast"/>
+	<rule ref="Universal.Arrays.DuplicateArrayKey"/>
+	<rule ref="Universal.Arrays.MixedArrayKeyTypes"/>
+	<rule ref="Universal.Arrays.MixedKeyedUnkeyedArray"/>
+	<rule ref="Universal.CodeAnalysis.ForeachUniqueAssignment" />
+	<rule ref="Universal.CodeAnalysis.NoEchoSprintf" />
+	<rule ref="Universal.CodeAnalysis.StaticInFinalClass" />
+	<rule ref="Universal.Constants.LowercaseClassResolutionKeyword" />
+	<rule ref="Universal.Constants.UppercaseMagicConstants" />
+	<rule ref="Universal.ControlStructures.DisallowLonelyIf" />
+	<rule ref="Universal.Namespaces.DisallowDeclarationWithoutName" />
+	<rule ref="Universal.Namespaces.OneDeclarationPerFile" />
+	<rule ref="Universal.NamingConventions.NoReservedKeywordParameterNames" />
+	<rele ref="Universal.Operators.DisallowLogicalAndOr" />
+	<rule ref="Universal.PHP.LowercasePHPTag" />
+	<rule ref="Universal.PHP.OneStatementInShortEchoTag" />
+	<rule ref="Universal.UseStatements.NoUselessAliases" />
+	<rule ref="Universal.WhiteSpace.DisallowInlineTabs">
+		<arg name="tab-width" value="4"/>
+	</rule>
+	<rule ref="Native.FunctionInvocation.NativeFunctionInvocation" />
+
 	<!--
 	#############################################################################
 	SELECTIVE EXCLUSIONS

tests/phpunit/class-task-provider-test-trait.php

@@ -34,7 +34,7 @@ trait Task_Provider_Test_Trait {
 	 *
 	 * @return void
 	 */
-	public static function setUpBeforeClass(): void { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
+	final public static function setUpBeforeClass(): void { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
 		// Set the current user to the admin user.
 		wp_set_current_user( 1 );
 	}
@@ -44,7 +44,7 @@ public static function setUpBeforeClass(): void { // phpcs:ignore WordPress.Nami
 	 *
 	 * @return void
 	 */
-	public static function tearDownAfterClass(): void { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
+	final public static function tearDownAfterClass(): void { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
 		// Reset the current user.
 		wp_set_current_user( 0 );
 	}
@@ -54,7 +54,7 @@ public static function tearDownAfterClass(): void { // phpcs:ignore WordPress.Na
 	 *
 	 * @return void
 	 */
-	public function set_up() {
+	final public function set_up() {
 		parent::set_up();
 
 		// Get the task provider.
@@ -69,7 +69,7 @@ public function set_up() {
 	 *
 	 * @return void
 	 */
-	public function tear_down() {
+	final public function tear_down() {
 		parent::tear_down();
 
 		// Delete local tasks.
@@ -91,7 +91,7 @@ abstract protected function complete_task();
 	 *
 	 * @return void
 	 */
-	public function test_task_provider() {
+	final public function test_task_provider() {
 
 		// Test that the blog description is empty.
 		$this->assertTrue( $this->task_provider->should_add_task() );