No need to modify Core behaviour

Author: aristath

assets/js/recommendations/disable-comment-pagination.js

@@ -6,10 +6,10 @@
  * Dependencies: progress-planner/recommendations/interactive-task
  */
 
-prplInteractiveTaskFormListener.siteSettings( {
-	settingAPIKey: 'page_comments',
+prplInteractiveTaskFormListener.settings( {
 	setting: 'page_comments',
+	settingPath: '{}',
 	taskId: 'disable-comment-pagination',
 	popoverId: 'prpl-popover-disable-comment-pagination',
-	settingCallbackValue: () => '',
+	settingCallbackValue: () => false,
 } );

assets/js/recommendations/interactive-task.js

@@ -109,8 +109,7 @@ const prplInteractiveTaskFormListener = {
 	settings: ( {
 		taskId,
 		setting,
-		value,
-		settingPath,
+		settingPath = false,
 		popoverId,
 		settingCallbackValue = ( settingValue ) => settingValue,
 	} = {} ) => {
@@ -136,7 +135,7 @@ const prplInteractiveTaskFormListener = {
 					_ajax_nonce: progressPlanner.nonce,
 					post_id: taskId,
 					setting,
-					value,
+					value: settingsToPass[ setting ],
 					setting_path: settingPath,
 				},
 			} ).then( () => {

classes/suggested-tasks/providers/class-disable-comment-pagination.php

@@ -33,36 +33,6 @@ class Disable_Comment_Pagination extends Tasks_Interactive {
 	 */
 	const POPOVER_ID = 'disable-comment-pagination';
 
-	/**
-	 * Initialize the task.
-	 *
-	 * @return void
-	 */
-	public function init() {
-		\add_action( 'rest_api_init', [ $this, 'register_setting_with_rest' ] );
-	}
-
-	/**
-	 * Register the setting with the REST API.
-	 *
-	 * @return void
-	 */
-	public function register_setting_with_rest() {
-		register_setting(
-			'discussion',
-			'page_comments',
-			[
-				'type'         => 'string',
-				'label'        => __( 'Break comments into pages', 'progress-planner' ),
-				'show_in_rest' => [
-					'schema' => [
-						'enum' => [ '1', '' ],
-					],
-				],
-			]
-		);
-	}
-
 	/**
 	 * Get the task URL.
 	 *

classes/suggested-tasks/providers/class-tasks-interactive.php

@@ -49,7 +49,6 @@ public function get_task_details( $task_data = [] ) {
 	 *
 	 * This is only for interactive tasks that change non-core settings.
 	 * The $_POST data is expected to be:
-	 * - post_id: (int) The post ID.
 	 * - setting: (string) The setting to update.
 	 * - value: (mixed) The value to update the setting to.
 	 * - setting_path: (array) The path to the setting to update.
@@ -66,10 +65,6 @@ public function handle_interactive_task_submit() {
 			\wp_send_json_error( [ 'message' => \esc_html__( 'Invalid nonce.', 'progress-planner' ) ] );
 		}
 
-		if ( ! isset( $_POST['post_id'] ) || ! isset( $_POST['action_type'] ) ) {
-			\wp_send_json_error( [ 'message' => \esc_html__( 'Missing data.', 'progress-planner' ) ] );
-		}
-
 		if ( ! isset( $_POST['setting'] ) ) {
 			\wp_send_json_error( [ 'message' => \esc_html__( 'Missing setting.', 'progress-planner' ) ] );
 		}