Skip to content

Commit c04d7bf

Browse files
committed
a11y fix
1 parent 64c1225 commit c04d7bf

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

assets/js/web-components/prpl-suggested-task.js

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -217,14 +217,15 @@ customElements.define(
217217
<slot name="open-icon">`;
218218
}
219219

220-
output += `<input
220+
output += `<label><input
221221
type="checkbox"
222-
id="prpl-suggested-task-checkbox-${ task_id }"
223222
class="prpl-suggested-task-checkbox"
224223
style="${ checkboxStyle }"
225224
${ ! dismissable ? 'disabled' : '' }
226225
${ getTaskStatus() === 'completed' ? 'checked' : '' }
227-
>`;
226+
><span class="screen-reader-text">${ taskHeading }: ${ prplL10n(
227+
'markAsComplete'
228+
) }</span></label>`;
228229

229230
if ( ! dismissable ) {
230231
output += `
@@ -260,17 +261,11 @@ customElements.define(
260261
>
261262
${ actionButtons.completeCheckbox }
262263
<h3 style="width: 100%;">
263-
${
264-
useCheckbox
265-
? `<label for="prpl-suggested-task-checkbox-${ task_id }">`
266-
: ''
267-
}
268264
<span${
269265
'user' === category
270266
? ` contenteditable="plaintext-only"`
271267
: ''
272268
}>${ taskHeading }</span>
273-
${ useCheckbox && dismissable ? `</label>` : '' }
274269
</h3>
275270
<div class="prpl-suggested-task-actions">
276271
<div class="tooltip-actions">
@@ -482,6 +477,12 @@ customElements.define(
482477
detail: { node: thisObj },
483478
} )
484479
);
480+
481+
h3Span
482+
.closest( '.prpl-suggested-task' )
483+
.querySelector(
484+
'label:has(.prpl-suggested-task-checkbox) .screen-reader-text'
485+
).innerHTML = title;
485486
} );
486487
}, 300 );
487488
} );

0 commit comments

Comments
 (0)