dont add activities for tasks which dont award points

Author: ilicfilip

CHANGELOG.md

@@ -4,6 +4,7 @@ Bugs we fixed:
 
 * Don't redirect user to Progress Planner dashboard if 'redirect_to' GET or POST parameter is set.
 * Fixed detecting creation of new valuable content posts.
+* Don't award point for all Todo tasks, only for golden.
 
 = 1.4.2 =
 

classes/class-suggested-tasks.php

@@ -581,8 +581,14 @@ public function suggested_task_action() {
 				// Mark the task as completed.
 				$this->mark_task_as( 'completed', $task_id );
 
-				// Insert an activity.
-				$this->insert_activity( $task_id );
+				$task_data = \progress_planner()->get_suggested_tasks()->get_tasks_by( 'task_id', $task_id );
+
+				// Insert an activity if task has points.
+				// User tasks have points saved in the task data (0 or 1). Other tasks don't, but they all award points.
+				if ( isset( $task_data[0] ) && ( ( 'user' !== $task_data[0]['provider_id'] || ( ( isset( $task_data[0]['points'] ) && 0 !== (int) $task_data[0]['points'] ) ) ) ) ) {
+					$this->insert_activity( $task_id );
+				}
+
 				$updated = true;
 				break;