More tweaks

Author: aristath

classes/class-base.php

@@ -43,6 +43,7 @@
  * @method \Progress_Planner\Plugin_Installer get_plugin_installer()
  * @method \Progress_Planner\Admin\Widgets\Badge_Streak_Content get_admin__widgets__badge_streak_content()
  * @method \Progress_Planner\Admin\Widgets\Badge_Streak_Maintenance get_admin__widgets__badge_streak_maintenance()
+ * @method \Progress_Planner\Admin\Enqueue get_admin__enqueue()
  */
 class Base {
 

classes/suggested-tasks/providers/class-content-review.php

@@ -204,7 +204,7 @@ public function should_add_task() {
 		// Add the privacy policy page ID if it exists. Not 'publish' page will not be fetched by get_posts().
 		$privacy_policy_page_id = \get_option( 'wp_page_for_privacy_policy' );
 		if ( $privacy_policy_page_id ) {
-			$important_page_ids[] = (int) $privacy_policy_page_id; // @phpstan-ignore-line cast.int
+			$important_page_ids[] = (int) $privacy_policy_page_id;
 		}
 
 		/**
@@ -506,7 +506,7 @@ protected function is_specific_task_completed( $task_id ) {
 		$data = $task->get_data();
 
 		return $data && isset( $data['target_post_id'] )
-			&& (int) \get_post_modified_time( 'U', false, (int) $data['target_post_id'] ) > \strtotime( '-12 months' ); // @phpstan-ignore-line cast.int
+			&& (int) \get_post_modified_time( 'U', false, (int) $data['target_post_id'] ) > \strtotime( '-12 months' );
 	}
 
 	/**

classes/suggested-tasks/providers/class-disable-comment-pagination.php

@@ -101,7 +101,7 @@ public function print_popover_instructions() {
 		\printf(
 			/* translators: %d is the number of comments per page, %s is the "recommend to disable comment pagination" link */
 			\esc_html__( 'When comment pagination is enabled, your site creates a new page for every %1$d comments. This is not helping your website in search engines, and can break up the ongoing conversation. That\'s why we %2$s.', 'progress-planner' ),
-			(int) \get_option( 'comments_per_page' ), // @phpstan-ignore-line cast.int
+			(int) \get_option( 'comments_per_page' ),
 			'<a href="https://prpl.fyi/disable-comment-pagination" target="_blank">' . \esc_html__( 'recommend to disable comment pagination', 'progress-planner' ) . '</a>'
 		);
 		echo '</p>';

classes/suggested-tasks/providers/class-hello-world.php

@@ -96,7 +96,7 @@ protected function get_title() {
 	 * @return string
 	 */
 	protected function get_description() {
-		$hello_world_post_id = (int) $this->get_data_collector()->collect(); // @phpstan-ignore-line cast.int
+		$hello_world_post_id = (int) $this->get_data_collector()->collect();
 
 		if ( 0 === $hello_world_post_id ) {
 			return \esc_html__( 'On install, WordPress creates a "Hello World!" post. This post is not needed and should be deleted.', 'progress-planner' );

classes/suggested-tasks/providers/class-rename-uncategorized-category.php

@@ -55,7 +55,7 @@ class Rename_Uncategorized_Category extends Tasks {
 	 * @return string
 	 */
 	protected function get_url() {
-		return \admin_url( 'term.php?taxonomy=category&tag_ID=' . (int) $this->get_data_collector()->collect() ); // @phpstan-ignore-line cast.int
+		return \admin_url( 'term.php?taxonomy=category&tag_ID=' . (int) $this->get_data_collector()->collect() );
 	}
 
 	/**
@@ -96,7 +96,7 @@ public function update_uncategorized_category_cache() {
 	public function add_task_actions( $data = [], $actions = [] ) {
 		$actions[] = [
 			'priority' => 10,
-			'html'     => '<a class="prpl-tooltip-action-text" href="' . \admin_url( 'term.php?taxonomy=category&tag_ID=' . (int) $this->get_data_collector()->collect() ) . '" target="_self">' . \esc_html__( 'Rename', 'progress-planner' ) . '</a>', // @phpstan-ignore-line cast.int
+			'html'     => '<a class="prpl-tooltip-action-text" href="' . \admin_url( 'term.php?taxonomy=category&tag_ID=' . (int) $this->get_data_collector()->collect() ) . '" target="_self">' . \esc_html__( 'Rename', 'progress-planner' ) . '</a>',
 		];
 
 		return $actions;

classes/suggested-tasks/providers/class-sample-page.php

@@ -95,7 +95,7 @@ protected function get_title() {
 	 * @return string
 	 */
 	protected function get_description() {
-		$sample_page_id = (int) $this->get_data_collector()->collect(); // @phpstan-ignore-line cast.int
+		$sample_page_id = (int) $this->get_data_collector()->collect();
 
 		if ( 0 === $sample_page_id ) {
 			return \esc_html__( 'On install, WordPress creates a "Sample Page" page. This page does not add value to your website and solely exists to show what a page can look like. Therefore, "Sample Page" is not needed and should be deleted.', 'progress-planner' );

classes/suggested-tasks/providers/class-search-engine-visibility.php

@@ -69,7 +69,7 @@ protected function get_title() {
 	 * @return bool
 	 */
 	public function should_add_task() {
-		return 0 === (int) \get_option( 'blog_public' ); // @phpstan-ignore-line cast.int
+		return 0 === (int) \get_option( 'blog_public' );
 	}
 
 	/**

classes/suggested-tasks/providers/class-select-timezone.php

@@ -112,8 +112,8 @@ public function print_popover_instructions() {
 	 * @return void
 	 */
 	public function print_popover_form_contents() {
-		$current_offset     = (float) \get_option( 'gmt_offset' ); // @phpstan-ignore-line cast.float
-		$tzstring           = (string) \get_option( 'timezone_string', '' ); // @phpstan-ignore-line cast.string
+		$current_offset     = (float) \get_option( 'gmt_offset' );
+		$tzstring           = (string) \get_option( 'timezone_string', '' );
 		$was_tzstring_saved = '' !== $tzstring || 0 !== (int) $current_offset ? 'true' : 'false';
 
 		// Remove old Etc mappings. Fallback to gmt_offset.

classes/suggested-tasks/providers/integrations/yoast/class-archive-date.php

@@ -82,7 +82,7 @@ public function should_add_task() {
 	 */
 	public function is_task_relevant() {
 		// If the permalink structure includes %year%, %monthnum%, or %day%, we don't need to add the task.
-		$permalink_structure = (string) \get_option( 'permalink_structure', '' ); // @phpstan-ignore-line cast.string
+		$permalink_structure = (string) \get_option( 'permalink_structure', '' );
 		return \strpos( $permalink_structure, '%year%' ) === false
 			&& \strpos( $permalink_structure, '%monthnum%' ) === false
 			&& \strpos( $permalink_structure, '%day%' ) === false;

classes/suggested-tasks/providers/traits/class-dismissable-task.php

@@ -165,7 +165,7 @@ protected function is_task_dismissed( $task_data ) {
 		}
 
 		// If the task was dismissed more than the expiration period ago, we can show it again.
-		if ( ( \time() - (int) $dismissal_data['timestamp'] ) > $this->get_expiration_period( $dismissal_data ) ) { // @phpstan-ignore-line cast.int
+		if ( ( \time() - (int) $dismissal_data['timestamp'] ) > $this->get_expiration_period( $dismissal_data ) ) {
 			unset( $dismissed_tasks[ $provider_key ][ $task_identifier ] );
 			\progress_planner()->get_settings()->set( $this->dismissed_tasks_option, $dismissed_tasks );
 			return false;
@@ -208,7 +208,7 @@ public function cleanup_old_dismissals() {
 			if ( ! \is_array( $data ) ) {
 				continue;
 			}
-			if ( ( \time() - (int) $data['timestamp'] ) > $this->get_expiration_period( $data ) ) { // @phpstan-ignore-line cast.int
+			if ( ( \time() - (int) $data['timestamp'] ) > $this->get_expiration_period( $data ) ) {
 				unset( $dismissed_tasks[ $provider_key ][ $identifier ] ); // @phpstan-ignore-line
 				$has_changes = true;
 			}