Merge pull request #646 from ProgressPlanner/filip/v19/fix-remove-term

Fix point sometimes not awarded for completing "Remove term without posts" task.

Author: aristath

CHANGELOG.md

@@ -7,6 +7,7 @@ Enhancements:
 Bugs we fixed:
 
 * Fix missing content and streak badges after they are all completed.
+* Fix issue when point is sometimes not awarded for completing "Remove term without posts" task.
 
 
 = 1.8.0 =

classes/suggested-tasks/providers/class-remove-terms-without-posts.php

@@ -128,7 +128,13 @@ public function maybe_remove_irrelevant_tasks( $object_id, $terms, $tt_ids, $tax
 			if ( $task->target_term_id && $task->target_taxonomy ) {
 				$term = \get_term( $task->target_term_id, $task->target_taxonomy );
 
-				if ( \is_wp_error( $term ) || ! $term || $term->count > self::MIN_POSTS ) {
+				// If the term is NULL it means the term was deleted, but we want to keep the task (and award a point).
+				if ( ! $term ) {
+					continue;
+				}
+
+				// If the taxonomy is not found the $term will be a WP_Error object.
+				if ( \is_wp_error( $term ) || $term->count > self::MIN_POSTS ) {
 					\progress_planner()->get_suggested_tasks_db()->delete_recommendation( $task->ID );
 				}
 			}