Skip to content

Commit d688e37

Browse files
committed
fix nested button
1 parent 92276ec commit d688e37

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

assets/js/web-components/prpl-tooltip.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,6 @@ customElements.define(
4949
openButton = document.createElement( 'button' );
5050
openButton.type = 'button';
5151
openButton.className = 'prpl-info-icon';
52-
openButton.setAttribute(
53-
'data-tooltip-action',
54-
'open-tooltip'
55-
);
5652
openButton.innerHTML =
5753
openIconSlot?.innerHTML ||
5854
`
@@ -62,6 +58,10 @@ customElements.define(
6258
</span>
6359
`;
6460
}
61+
62+
// Add data attribute to the open button.
63+
openButton.setAttribute( 'data-tooltip-action', 'open-tooltip' );
64+
6565
openSlot?.remove(); // Remove slot element
6666
openIconSlot?.remove(); // Remove slot element
6767

views/js-templates/suggested-task.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ <h3 style="width: 100%;">
2828
<div class="tooltip-actions">
2929
<# if ( data.post.content.rendered !== '' ) { #>
3030
<prpl-tooltip>
31-
<slot name="open-icon">
31+
<slot name="open">
3232
<button type="button" class="prpl-suggested-task-button" data-task-id="{{ data.post.meta.prpl_task_id }}" data-task-title="{{ data.post.title.rendered }}" data-action="info" data-target="info" title="{{ data.l10n.info }}">
3333
<img src="{{ data.assets.infoIcon }}" alt="{{ data.l10n.info }}" class="icon">
3434
<span class="screen-reader-text">{{ data.l10n.info }}</span>
@@ -52,7 +52,7 @@ <h3 style="width: 100%;">
5252

5353
<# if ( data.post.meta.prpl_snoozable ) { #>
5454
<prpl-tooltip class="prpl-suggested-task-snooze">
55-
<slot name="open-icon">
55+
<slot name="open">
5656
<button type="button" class="prpl-suggested-task-button" data-task-id="{{ data.post.meta.prpl_task_id }}" data-task-title="{{ data.post.title.rendered }}" data-action="snooze" data-target="snooze" title="{{ data.l10n.snooze }}">
5757
<img src="{{ data.assets.snoozeIcon }}" alt="{{ data.l10n.snooze }}" class="icon">
5858
<span class="screen-reader-text">{{ data.l10n.snooze }}</span>

0 commit comments

Comments
 (0)