Remove get_description methods where possible

Author: aristath

classes/suggested-tasks/providers/class-content-review.php

@@ -151,35 +151,6 @@ protected function get_title_with_data( $task_data = [] ) {
 		);
 	}
 
-	/**
-	 * Get the task description.
-	 *
-	 * @param array $task_data The task data.
-	 *
-	 * @return string
-	 */
-	protected function get_description_with_data( $task_data = [] ) {
-		if ( ! isset( $task_data['target_post_id'] ) ) {
-			return '';
-		}
-
-		$post = \get_post( $task_data['target_post_id'] );
-
-		if ( ! $post ) {
-			return '';
-		}
-
-		$months = \in_array( (int) $post->ID, $this->get_saved_page_types(), true ) ? '12' : '6';
-
-		return '<p>' . \sprintf(
-			/* translators: %1$s <a href="https://prpl.fyi/review-post" target="_blank">Review</a> link, %2$s: The post title, %3$s: The number of months. */
-			\esc_html__( '%1$s the post "%2$s" as it was last updated more than %3$s months ago.', 'progress-planner' ),
-			'<a href="https://prpl.fyi/review-post" target="_blank">' . \esc_html__( 'Review', 'progress-planner' ) . '</a>',
-			\esc_html( $post->post_title ), // @phpstan-ignore-line property.nonObject
-			\esc_html( $months )
-		) . '</p>';
-	}
-
 	/**
 	 * Get the task URL.
 	 *
@@ -328,7 +299,6 @@ public function get_tasks_to_inject() {
 				'target_post_type'  => $task_data['target_post_type'],
 				'date'              => \gmdate( 'YW' ),
 				'post_title'        => $this->get_title_with_data( $task_data ),
-				'description'       => $this->get_description_with_data( $task_data ),
 				'url'               => $this->get_url_with_data( $task_data ),
 				'url_target'        => $this->get_url_target(),
 				'dismissable'       => $this->is_dismissable(),

classes/suggested-tasks/providers/class-core-update.php

@@ -83,15 +83,6 @@ protected function get_title() {
 		return \esc_html__( 'Perform all updates', 'progress-planner' );
 	}
 
-	/**
-	 * Get the task description.
-	 *
-	 * @return string
-	 */
-	protected function get_description() {
-		return \esc_html__( 'Regular updates improve security and performance.', 'progress-planner' );
-	}
-
 	/**
 	 * Add the link to the Progress Planner Dashboard to the update complete actions.
 	 *

classes/suggested-tasks/providers/class-debug-display.php

@@ -42,20 +42,6 @@ protected function get_title() {
 		return \esc_html__( 'Disable public display of PHP errors', 'progress-planner' );
 	}
 
-	/**
-	 * Get the task description.
-	 *
-	 * @param array $task_data Optional data to include in the task.
-	 * @return string
-	 */
-	protected function get_description( $task_data = [] ) {
-		return \sprintf(
-			// translators: %s is the name of the WP_DEBUG_DISPLAY constant.
-			\esc_html__( '%s is enabled. This means that errors are shown to users. We recommend disabling it.', 'progress-planner' ),
-			'<code>WP_DEBUG_DISPLAY</code>',
-		);
-	}
-
 	/**
 	 * Check if the task should be added.
 	 *

classes/suggested-tasks/providers/class-disable-comment-pagination.php

@@ -70,19 +70,6 @@ protected function get_title() {
 		return \esc_html__( 'Disable comment pagination', 'progress-planner' );
 	}
 
-	/**
-	 * Get the task description.
-	 *
-	 * @return string
-	 */
-	protected function get_description() {
-		return \sprintf(
-			/* translators: %d is the number of comments per page.*/
-			\esc_html__( 'When comment pagination is enabled, your site creates a new page for every %d comments. This is not helping your website in search engines, and can break up the ongoing conversation. That\'s why we recommend to disable comment pagination.', 'progress-planner' ),
-			(int) \get_option( 'comments_per_page' ),
-		);
-	}
-
 	/**
 	 * Check if the task condition is satisfied.
 	 * (bool) true means that the task condition is satisfied, meaning that we don't need to add the task or task was completed.

classes/suggested-tasks/providers/class-disable-comments.php

@@ -70,26 +70,6 @@ protected function get_title() {
 		return \esc_html__( 'Disable comments', 'progress-planner' );
 	}
 
-	/**
-	 * Get the task description.
-	 *
-	 * @return string
-	 */
-	protected function get_description() {
-		return \sprintf(
-			\esc_html(
-				// translators: %d is the number of approved comments.
-				\_n(
-					'There is %1$d comment. If you don\'t need comments on your site, consider disabling them.',
-					'There are %1$d comments. If you don\'t need comments on your site, consider disabling them.',
-					(int) \wp_count_comments()->approved,
-					'progress-planner'
-				)
-			),
-			(int) \wp_count_comments()->approved,
-		);
-	}
-
 	/**
 	 * Check if the task condition is satisfied.
 	 * (bool) true means that the task condition is satisfied, meaning that we don't need to add the task or task was completed.

classes/suggested-tasks/providers/class-fewer-tags.php

@@ -113,20 +113,6 @@ protected function get_title() {
 		return \esc_html__( 'Install Fewer Tags and clean up your tags', 'progress-planner' );
 	}
 
-	/**
-	 * Get the description.
-	 *
-	 * @return string
-	 */
-	protected function get_description() {
-		return \sprintf(
-			// translators: %1$s is the number of tags, %2$s is the number of published posts.
-			\esc_html__( 'We detected that you have %1$s tags and %2$s published posts. Consider installing the "Fewer Tags" plugin.', 'progress-planner' ),
-			$this->post_tag_count_data_collector->collect(),
-			$this->published_post_count_data_collector->collect(),
-		);
-	}
-
 	/**
 	 * Check if the task condition is satisfied.
 	 * (bool) true means that the task condition is satisfied, meaning that we don't need to add the task or task was completed.

classes/suggested-tasks/providers/class-permalink-structure.php

@@ -78,15 +78,6 @@ protected function get_title() {
 		return \esc_html__( 'Set permalink structure', 'progress-planner' );
 	}
 
-	/**
-	 * Get the description.
-	 *
-	 * @return string
-	 */
-	protected function get_description() {
-		return \esc_html__( 'On install, WordPress sets the permalink structure to a format that is not SEO-friendly. We recommend changing it.', 'progress-planner' );
-	}
-
 	/**
 	 * Check if the task condition is satisfied.
 	 * (bool) true means that the task condition is satisfied, meaning that we don't need to add the task or task was completed.

classes/suggested-tasks/providers/class-php-version.php

@@ -49,21 +49,6 @@ protected function get_title() {
 		return \esc_html__( 'Update PHP version', 'progress-planner' );
 	}
 
-	/**
-	 * Get the description.
-	 *
-	 * @param array $task_data Optional data to include in the task.
-	 * @return string
-	 */
-	protected function get_description( $task_data = [] ) {
-		return \sprintf(
-			/* translators: %1$s: php version, %2$s: minimum PHP version recommended. */
-			\esc_html__( 'Your site is running on PHP version %1$s. We recommend updating to PHP version %2$s or higher.', 'progress-planner' ),
-			\phpversion(),
-			\esc_html( self::RECOMMENDED_PHP_VERSION )
-		);
-	}
-
 	/**
 	 * Check if the task should be added.
 	 *

classes/suggested-tasks/providers/class-remove-inactive-plugins.php

@@ -60,15 +60,6 @@ protected function get_title() {
 		return \esc_html__( 'Remove inactive plugins', 'progress-planner' );
 	}
 
-	/**
-	 * Get the description.
-	 *
-	 * @return string
-	 */
-	protected function get_description() {
-		return \esc_html__( 'You have inactive plugins. Consider removing any plugins that are not activated to free up resources, and improve security.', 'progress-planner' );
-	}
-
 	/**
 	 * Check if the task should be added.
 	 *

classes/suggested-tasks/providers/class-remove-terms-without-posts.php

@@ -153,25 +153,6 @@ protected function get_title_with_data( $task_data = [] ) {
 			: '';
 	}
 
-	/**
-	 * Get the description.
-	 *
-	 * @param array $task_data The task data.
-	 *
-	 * @return string
-	 */
-	protected function get_description_with_data( $task_data = [] ) {
-		$term = \get_term( $task_data['target_term_id'], $task_data['target_taxonomy'] );
-		return ( $term && ! \is_wp_error( $term ) )
-			? \sprintf(
-				/* translators: %1$s: The term name, %2$s <a href="https://prpl.fyi/remove-empty-taxonomy" target="_blank">Read more</a> link */
-				\esc_html__( 'The "%1$s" term has one or less posts associated with it, we recommend removing it. %2$s', 'progress-planner' ),
-				$term->name,
-				'<a href="https://prpl.fyi/remove-empty-taxonomy" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Read more about the removing the empty terms', 'progress-planner' ) . '">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
-			)
-			: '';
-	}
-
 	/**
 	 * Get the URL.
 	 *