Skip to content

Commit daaa10b

Browse files
aristatharistath
authored
Merge pull request #461 from ProgressPlanner/filip/v14/adjust-task-wording
Update title and description for Yoast SEO tasks
2 parents 2a868b8 + 6b169b9 commit daaa10b

9 files changed

Lines changed: 27 additions & 26 deletions

‎classes/suggested-tasks/providers/class-fewer-tags.php‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,11 @@ public function get_title() {
100100
*/
101101
public function get_description() {
102102
return sprintf(
103-
// translators: %1$s is the number of tags, %2$s is the number of published posts.
104-
\esc_html__( 'We detected that you have %1$s tags and %2$s published posts. Consider installing the "Fewer Tags" plugin.', 'progress-planner' ),
103+
// translators: %1$s is the number of tags, %2$s is the number of published posts, %3$s <a href="https://prpl.fyi/install-fewer-tags/" target="_blank">Read more</a> link.
104+
\esc_html__( 'We detected that you have %1$s tags and %2$s published posts. Consider installing the "Fewer Tags" plugin. %3$s', 'progress-planner' ),
105105
$this->post_tag_count_data_collector->collect(),
106106
$this->published_post_count_data_collector->collect(),
107+
'<a href="https://prpl.fyi/install-fewer-tags/" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Read more about the Fewer Tags plugin', 'progress-planner' ) . '">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
107108
);
108109
}
109110

‎classes/suggested-tasks/providers/class-remove-terms-without-posts.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ public function get_title( $task_id = '' ) {
165165

166166
return \sprintf(
167167
/* translators: %s: The term name */
168-
\esc_html__( 'Remove %s term', 'progress-planner' ),
168+
\esc_html__( 'Remove term named "%s"', 'progress-planner' ),
169169
\esc_html( $task_data[0]['term_name'] )
170170
);
171171
}
@@ -185,10 +185,10 @@ public function get_description( $task_id = '' ) {
185185
}
186186

187187
return sprintf(
188-
/* translators: %1$s: The term name, %2$s <a href="https://prpl.fyi/remove-term" target="_blank">Read more</a> link */
189-
\esc_html__( 'The %1$s term has one or less posts associated with it, we recommend removing it. %2$s', 'progress-planner' ),
188+
/* translators: %1$s: The term name, %2$s <a href="https://prpl.fyi/remove-empty-taxonomy/" target="_blank">Read more</a> link */
189+
\esc_html__( 'The "%1$s" term has one or less posts associated with it, we recommend removing it. %2$s', 'progress-planner' ),
190190
$term->name,
191-
'<a href="https://prpl.fyi/remove-term" target="_blank">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
191+
'<a href="https://prpl.fyi/remove-empty-taxonomy/" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Read more about the removing the empty terms', 'progress-planner' ) . '">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
192192
);
193193
}
194194

‎classes/suggested-tasks/providers/class-update-term-description.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ public function get_title( $task_id = '' ) {
156156

157157
return \sprintf(
158158
/* translators: %s: The term name */
159-
\esc_html__( 'Write a description for %s', 'progress-planner' ),
159+
\esc_html__( 'Write a description for term named "%s"', 'progress-planner' ),
160160
\esc_html( $task_data[0]['term_name'] )
161161
);
162162
}
@@ -176,10 +176,10 @@ public function get_description( $task_id = '' ) {
176176
}
177177

178178
return sprintf(
179-
/* translators: %1$s: The term name, %2$s <a href="https://prpl.fyi/update-term-description" target="_blank">Read more</a> link */
180-
\esc_html__( 'Your %1$s archives probably show the description of that specific term. %2$s', 'progress-planner' ),
179+
/* translators: %1$s: The term name, %2$s <a href="https://prpl.fyi/taxonomy-terms-description/" target="_blank">Read more</a> link */
180+
\esc_html__( 'Your "%1$s" archives probably show the description of that specific term. %2$s', 'progress-planner' ),
181181
$term->name,
182-
'<a href="https://prpl.fyi/update-term-description" target="_blank">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
182+
'<a href="https://prpl.fyi/taxonomy-terms-description/" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Read more about the writing a description for taxonomy terms.', 'progress-planner' ) . '">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
183183
);
184184
}
185185

‎classes/suggested-tasks/providers/integrations/yoast/class-cornerstone-workout.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public function maybe_update_workout_status( $old_value, $value, $option ) {
116116
* @return string
117117
*/
118118
public function get_title( $task_id = '' ) {
119-
return \esc_html__( 'Run Yoast SEO Cornerstone Content Workout', 'progress-planner' );
119+
return \esc_html__( 'Yoast SEO: do Yoast SEO\'s Cornerstone Content Workout', 'progress-planner' );
120120
}
121121

122122
/**
@@ -129,8 +129,8 @@ public function get_title( $task_id = '' ) {
129129
public function get_description( $task_id = '' ) {
130130
return sprintf(
131131
/* translators: %s: "Read more" link. */
132-
\esc_html__( 'Run the Yoast SEO Cornerstone Content Workout to improve your site\'s SEO. %s.', 'progress-planner' ),
133-
'<a href="https://prpl.fyi/yoast-cornerstone" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Read more about the Yoast SEO Cornerstone Content Workout', 'progress-planner' ) . '">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
132+
\esc_html__( 'Improve your most important pages with Yoast SEO\'s Cornerstone Content Workout. %s.', 'progress-planner' ),
133+
'<a href="https://prpl.fyi/run-cornerstone-content-workout/" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Learn more about the Yoast SEO Cornerstone Content Workout', 'progress-planner' ) . '">' . \esc_html__( 'Learn more', 'progress-planner' ) . '</a>'
134134
);
135135
}
136136

@@ -142,7 +142,7 @@ public function get_description( $task_id = '' ) {
142142
* @return string
143143
*/
144144
public function get_url( $task_id = '' ) {
145-
return $this->capability_required() ? \esc_url( admin_url( 'admin.php?page=wpseo_workouts' ) ) : '';
145+
return $this->capability_required() ? \esc_url( admin_url( 'admin.php?page=wpseo_workouts#cornerstone' ) ) : '';
146146
}
147147

148148
/**
@@ -151,7 +151,7 @@ public function get_url( $task_id = '' ) {
151151
* @return bool
152152
*/
153153
public function should_add_task() {
154-
if ( ! function_exists( 'YoastSEO' ) ) {
154+
if ( ! defined( 'WPSEO_PREMIUM_VERSION' ) ) {
155155
return false;
156156
}
157157

‎classes/suggested-tasks/providers/integrations/yoast/class-crawl-settings-emoji-scripts.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function __construct() {
3232
* @return string
3333
*/
3434
public function get_title() {
35-
return \esc_html__( 'Yoast SEO: Remove emoji scripts', 'progress-planner' );
35+
return \esc_html__( 'Yoast SEO: remove emoji scripts', 'progress-planner' );
3636
}
3737

3838
/**

‎classes/suggested-tasks/providers/integrations/yoast/class-crawl-settings-feed-authors.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function __construct() {
4949
* @return string
5050
*/
5151
public function get_title() {
52-
return \esc_html__( 'Yoast SEO: Remove post authors feeds', 'progress-planner' );
52+
return \esc_html__( 'Yoast SEO: remove post authors feeds', 'progress-planner' );
5353
}
5454

5555
/**

‎classes/suggested-tasks/providers/integrations/yoast/class-crawl-settings-feed-global-comments.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function __construct() {
3232
* @return string
3333
*/
3434
public function get_title() {
35-
return \esc_html__( 'Yoast SEO: Remove global comment feeds', 'progress-planner' );
35+
return \esc_html__( 'Yoast SEO: remove global comment feeds', 'progress-planner' );
3636
}
3737

3838
/**

‎classes/suggested-tasks/providers/integrations/yoast/class-fix-orphaned-content.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function get_title( $task_id = '' ) {
110110

111111
return sprintf(
112112
/* translators: %s: Post title. */
113-
\esc_html__( 'Yoast SEO: Article %s has no links - fix it!', 'progress-planner' ),
113+
\esc_html__( 'Yoast SEO: add internal links to article "%s"!', 'progress-planner' ),
114114
\esc_html( $task_data[0]['post_title'] )
115115
);
116116
}
@@ -125,7 +125,7 @@ public function get_description( $task_id = '' ) {
125125
return sprintf(
126126
/* translators: %s: "Read more" link. */
127127
\esc_html__( 'Yoast SEO detected that this article has no links pointing to it. %s.', 'progress-planner' ),
128-
'<a href="#" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Read more about the Yoast SEO Orphaned Content Workout', 'progress-planner' ) . '">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
128+
'<a href="https://prpl.fyi/fix-orphaned-content/" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Read more about the fixing the orphaned content.', 'progress-planner' ) . '">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
129129
);
130130
}
131131

@@ -144,7 +144,7 @@ public function get_url( $task_id = '' ) {
144144
return '';
145145
}
146146

147-
return \admin_url( 'post.php?post=' . $post->ID . '&action=edit' );
147+
return 'https://prpl.fyi/fix-orphaned-content/';
148148
}
149149

150150
/**

‎classes/suggested-tasks/providers/integrations/yoast/class-orphaned-content-workout.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public function maybe_update_workout_status( $old_value, $value, $option ) {
115115
* @return string
116116
*/
117117
public function get_title( $task_id = '' ) {
118-
return \esc_html__( 'Run Yoast SEO Orphaned Content Workout', 'progress-planner' );
118+
return \esc_html__( 'Yoast SEO: do Yoast SEO\'s Orphaned Content Workout', 'progress-planner' );
119119
}
120120

121121
/**
@@ -128,8 +128,8 @@ public function get_title( $task_id = '' ) {
128128
public function get_description( $task_id = '' ) {
129129
return sprintf(
130130
/* translators: %s: "Read more" link. */
131-
\esc_html__( 'Run the Yoast SEO Orphaned Content Workout to improve your site\'s SEO. %s.', 'progress-planner' ),
132-
'<a href="https://prpl.fyi/yoast-orphaned-content" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Read more about the Yoast SEO Orphaned Content Workout', 'progress-planner' ) . '">' . \esc_html__( 'Read more', 'progress-planner' ) . '</a>'
131+
\esc_html__( 'Improve your internal linking structure with Yoast SEO\'s Orphaned Content Workout. %s.', 'progress-planner' ),
132+
'<a href="https://prpl.fyi/run-orphaned-content-workout/" target="_blank" data-prpl_accessibility_text="' . \esc_attr__( 'Learn more about the Yoast SEO Orphaned Content Workout', 'progress-planner' ) . '">' . \esc_html__( 'Lean more', 'progress-planner' ) . '</a>'
133133
);
134134
}
135135

@@ -141,7 +141,7 @@ public function get_description( $task_id = '' ) {
141141
* @return string
142142
*/
143143
public function get_url( $task_id = '' ) {
144-
return $this->capability_required() ? \esc_url( admin_url( 'admin.php?page=wpseo_workouts' ) ) : '';
144+
return $this->capability_required() ? \esc_url( admin_url( 'admin.php?page=wpseo_workouts#orphaned' ) ) : '';
145145
}
146146

147147
/**
@@ -150,7 +150,7 @@ public function get_url( $task_id = '' ) {
150150
* @return bool
151151
*/
152152
public function should_add_task() {
153-
if ( ! function_exists( 'YoastSEO' ) ) {
153+
if ( ! defined( 'WPSEO_PREMIUM_VERSION' ) ) {
154154
return false;
155155
}
156156

0 commit comments

Comments
 (0)