Minor coding tweaks

Author: aristath

classes/class-suggested-tasks-db.php

@@ -307,7 +307,7 @@ public function get_post( $id ) {
 	 *
 	 * @param array $params The parameters to filter by ([ 'provider' => 'provider_id' ] etc).
 	 *
-	 * @return array<\Progress_Planner\Suggested_Tasks\Task>
+	 * @return \Progress_Planner\Suggested_Tasks\Task[]
 	 */
 	public function get_tasks_by( $params ) {
 		$args = [];
@@ -353,7 +353,7 @@ public function get_tasks_by( $params ) {
 	 *
 	 * @param array $args The arguments.
 	 *
-	 * @return array<\Progress_Planner\Suggested_Tasks\Task>
+	 * @return \Progress_Planner\Suggested_Tasks\Task[]
 	 */
 	public function get( $args = [] ) {
 		$args = \wp_parse_args(

classes/class-suggested-tasks.php

@@ -351,11 +351,7 @@ public function register_post_type() {
 	 * @return int
 	 */
 	public function change_trashed_posts_lifetime( $days, $post ) {
-		if ( 'prpl_recommendations' === $post->post_type ) {
-			return 60;
-		}
-
-		return $days;
+		return 'prpl_recommendations' === $post->post_type ? 60 : $days;
 	}
 
 	/**

classes/suggested-tasks/class-tasks-manager.php

@@ -210,7 +210,7 @@ public function inject_tasks() {
 	/**
 	 * Evaluate tasks stored in the option.
 	 *
-	 * @return array<\Progress_Planner\Suggested_Tasks\Task>
+	 * @return \Progress_Planner\Suggested_Tasks\Task[]
 	 */
 	public function evaluate_tasks(): array {
 		$tasks           = (array) \progress_planner()->get_suggested_tasks_db()->get_tasks_by( [ 'post_status' => 'publish' ] );

classes/suggested-tasks/providers/class-collaborator.php

@@ -67,11 +67,9 @@ protected function is_specific_task_completed( $task_id ) {
 
 		$task_data = $tasks[0]->get_data();
 
-		if ( isset( $task_data['is_completed_callback'] ) && is_callable( $task_data['is_completed_callback'] ) ) {
-			return call_user_func( $task_data['is_completed_callback'], $task_id );
-		}
-
-		return false;
+		return isset( $task_data['is_completed_callback'] ) && is_callable( $task_data['is_completed_callback'] )
+			? call_user_func( $task_data['is_completed_callback'], $task_id )
+			: false;
 	}
 
 	/**
@@ -82,7 +80,6 @@ protected function is_specific_task_completed( $task_id ) {
 	 * @return array
 	 */
 	public function get_task_details( $task_data = [] ) {
-
 		$tasks = \progress_planner()->get_settings()->get( 'tasks', [] );
 
 		foreach ( $tasks as $task ) {