attachments have post status inherit, not publish

ilicfilip · ilicfilip · commit f887528438f1 · 2025-10-27T11:42:09.000+01:00
diff --git a/classes/suggested-tasks/providers/class-improve-pdf-handling.php b/classes/suggested-tasks/providers/class-improve-pdf-handling.php
@@ -92,7 +92,7 @@ public function should_add_task() {
 				[
 					'post_type'      => 'attachment',
 					'post_mime_type' => 'application/pdf',
-					'post_status'    => 'publish',
+					'post_status'    => 'inherit',
 					'posts_per_page' => static::MIN_PDF_FILES + 1, // We want to get at least 11 PDF files to be sure we have enough.
 					'fields'         => 'ids',
 				]
@@ -101,7 +101,7 @@ public function should_add_task() {
 			\progress_planner()->get_utils__cache()->set( 'pdf_files_count', $pdf_files_count, DAY_IN_SECONDS );
 		}
 
-		return static::MIN_PDF_FILES < $pdf_files_count;
+		return static::MIN_PDF_FILES < (int) $pdf_files_count;
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public function should_add_task() {`
`92`	`92`	`[`
`93`	`93`	`'post_type' => 'attachment',`
`94`	`94`	`'post_mime_type' => 'application/pdf',`
`95`		`- 'post_status' => 'publish',`
	`95`	`+ 'post_status' => 'inherit',`
`96`	`96`	`'posts_per_page' => static::MIN_PDF_FILES + 1, // We want to get at least 11 PDF files to be sure we have enough.`
`97`	`97`	`'fields' => 'ids',`
`98`	`98`	`]`
`@@ -101,7 +101,7 @@ public function should_add_task() {`
`101`	`101`	`\progress_planner()->get_utils__cache()->set( 'pdf_files_count', $pdf_files_count, DAY_IN_SECONDS );`
`102`	`102`	`}`
`103`	`103`
`104`		`- return static::MIN_PDF_FILES < $pdf_files_count;`
	`104`	`+ return static::MIN_PDF_FILES < (int) $pdf_files_count;`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`/**`