Add spinner (loader) to the interactive tasks forms - #685
Merged
Conversation
Contributor
|
Test on Playground |
ilicfilip
changed the title
tacoverdo
approved these changes
Oct 24, 2025
tacoverdo
left a comment
tacoverdo
left a comment
Contributor
There was a problem hiding this comment.
Tested in Playground and on a live website. The spinner is working on either the left or right side of the button, as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this comment
Interactive tasks look similar, almost the same, but their HTML structure and the way they are submitted is different.
One example of different HTML structure is how submit button is positioned, for tasks which have multiple steps it is in the bottom right corner. But tasks which only have that button (like "Disable comments") will have it in the top left.
Spinner needs to be added to the side of the button which has available space (so the button is not moved when spinner is visible) and I have tried not to change how buttons were positioned before, but because there are many different variations another round of testing would be good.