fix: resolve index out of range panic in fetchContainerInfo for Ascend devices

- Pre-allocate bizContainerDevices based on actual container count
  to prevent out-of-bounds access when annotation device count
  differs from pod container count
- Merge devices from all device types per container instead of
  overwriting, which previously caused device data loss for
  multi-device-type pods
- Add container index boundary check in DecodePodDevices Ascend
  branch to align with NVIDIA/Hygon/Metax device handling

Fixes #94

Signed-off-by: handong <cygnushan@yunify.com>

Author: cygnus-yunify

server/internal/data/pod.go

@@ -112,11 +112,23 @@ func (r *podRepo) fetchContainerInfo(pod *corev1.Pod) []*biz.Container {
 	if err != nil {
 		return containers
 	}
-	bizContainerDevices := []biz.ContainerDevices{}
+	// Merge devices from all device types per container index.
+	// pdevices: map[deviceType]PodSingleDevice([]ContainerDevices)
+	numContainers := len(pod.Spec.Containers)
+	bizContainerDevices := make([]biz.ContainerDevices, numContainers)
 	for _, pds := range pdevices {
-		copier.Copy(&bizContainerDevices, pds)
+		var bizPds biz.PodSingleDevice
+		if err := copier.Copy(&bizPds, pds); err != nil {
+			r.log.Warnf("failed to copy pod device info: %v", err)
+			continue
+		}
+		for i, cd := range bizPds {
+			if i < numContainers {
+				bizContainerDevices[i] = append(bizContainerDevices[i], cd...)
+			}
+		}
 	}
-	if len(bizContainerDevices) < 1 {
+	if len(pdevices) == 0 {
 		return containers
 	}
 

server/internal/provider/util/util.go

@@ -317,7 +317,14 @@ func DecodePodDevices(pod *corev1.Pod, log *log.Helper) (PodDevices, error) {
 		pd[devType] = make(PodSingleDevice, 0)
 		switch devType {
 		case AscendGPUDevice, Ascend310PGPUDevice:
-			for _, s := range strings.Split(str, OnePodMultiContainerSplitSymbol) {
+			for i, s := range strings.Split(str, OnePodMultiContainerSplitSymbol) {
+				if i >= len(pod.Spec.Containers) {
+					break
+				}
+				if s == "" {
+					pd[devType] = append(pd[devType], ContainerDevices{})
+					continue
+				}
 				cd, err := DecodeNpuContainerDevices(s)
 				if err != nil {
 					return PodDevices{}, nil

server/internal/provider/util/util_test.go

@@ -16,8 +16,13 @@ limitations under the License.
 package util
 
 import (
-	"github.com/go-kratos/kratos/v2/log"
+	"os"
+	"reflect"
 	"testing"
+
+	"github.com/go-kratos/kratos/v2/log"
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
 var inRequestDevices map[string]string
@@ -345,3 +350,163 @@ func Test_DecodePodDevices(t *testing.T) {
 		})
 	}
 }
+
+func Test_DecodePodDevices_Ascend(t *testing.T) {
+	// Ensure Ascend device keys are registered in SupportDevices.
+	SupportDevices["Ascend"] = "hami.io/Ascend910B-devices-allocated"
+	SupportDevices["Ascend310P"] = "hami.io/Ascend310P-devices-allocated"
+	t.Cleanup(func() {
+		delete(SupportDevices, "Ascend")
+		delete(SupportDevices, "Ascend310P")
+	})
+
+	logger := log.NewHelper(log.NewStdLogger(os.Stdout))
+
+	tests := []struct {
+		name        string
+		pod         *corev1.Pod
+		want        PodDevices
+		wantErr bool
+	}{
+		{
+			name: "Ascend310P single container single device",
+			pod: &corev1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					Annotations: map[string]string{
+						"hami.io/Ascend310P-devices-allocated": "E0766E64-20C0AB59-CC9AB1A4-3778030A-83003019,Ascend310P,6144,100:",
+					},
+				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{{Name: "main"}},
+				},
+			},
+			want: PodDevices{
+				"Ascend310P": {
+					{
+						{Idx: 0, UUID: "E0766E64-20C0AB59-CC9AB1A4-3778030A-83003019", Type: "Ascend310P", Usedmem: 6144, Usedcores: 25},
+					},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "Ascend310P two containers",
+			pod: &corev1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					Annotations: map[string]string{
+						"hami.io/Ascend310P-devices-allocated": "E0766E64-20C0AB59-CC9AB1A4-3778030A-83003019,Ascend310P,6144,100:;D7E96E64-214123F1-E8E618E4-AED8030A-E3003039,Ascend310P,6144,100:",
+					},
+				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{
+						{Name: "ctr1"},
+						{Name: "ctr2"},
+					},
+				},
+			},
+			want: PodDevices{
+				"Ascend310P": {
+					{
+						{Idx: 0, UUID: "E0766E64-20C0AB59-CC9AB1A4-3778030A-83003019", Type: "Ascend310P", Usedmem: 6144, Usedcores: 25},
+					},
+					{
+						{Idx: 0, UUID: "D7E96E64-214123F1-E8E618E4-AED8030A-E3003039", Type: "Ascend310P", Usedmem: 6144, Usedcores: 25},
+					},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "Ascend310P annotation segments exceed container count - should truncate",
+			pod: &corev1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					Annotations: map[string]string{
+						// Two device segments but only one container in spec.
+						"hami.io/Ascend310P-devices-allocated": "E0766E64-20C0AB59-CC9AB1A4-3778030A-83003019,Ascend310P,6144,100:;D7E96E64-214123F1-E8E618E4-AED8030A-E3003039,Ascend310P,6144,100:",
+					},
+				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{{Name: "main"}},
+				},
+			},
+			want: PodDevices{
+				"Ascend310P": {
+					{
+						{Idx: 0, UUID: "E0766E64-20C0AB59-CC9AB1A4-3778030A-83003019", Type: "Ascend310P", Usedmem: 6144, Usedcores: 25},
+					},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "Ascend310P empty segment in middle should produce empty ContainerDevices placeholder",
+			pod: &corev1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					Annotations: map[string]string{
+						"hami.io/Ascend310P-devices-allocated": "E0766E64-20C0AB59-CC9AB1A4-3778030A-83003019,Ascend310P,6144,100:;;D7E96E64-214123F1-E8E618E4-AED8030A-E3003039,Ascend310P,6144,100:",
+					},
+				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{
+						{Name: "ctr1"},
+						{Name: "ctr2"},
+						{Name: "ctr3"},
+					},
+				},
+			},
+			want: PodDevices{
+				"Ascend310P": {
+					{
+						{Idx: 0, UUID: "E0766E64-20C0AB59-CC9AB1A4-3778030A-83003019", Type: "Ascend310P", Usedmem: 6144, Usedcores: 25},
+					},
+					{}, // empty segment placeholder
+					{
+						{Idx: 0, UUID: "D7E96E64-214123F1-E8E618E4-AED8030A-E3003039", Type: "Ascend310P", Usedmem: 6144, Usedcores: 25},
+					},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "Ascend310P malformed device should produce empty device set",
+			pod: &corev1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					Annotations: map[string]string{
+						"hami.io/Ascend310P-devices-allocated": "bad-format-string",
+					},
+				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{{Name: "main"}},
+				},
+			},
+			want:    PodDevices{"Ascend310P": {}},
+			wantErr: false,
+		},
+		{
+			name: "empty annotations should return empty PodDevices",
+			pod: &corev1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					Annotations: map[string]string{},
+				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{{Name: "main"}},
+				},
+			},
+			want:    PodDevices{},
+			wantErr: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := DecodePodDevices(tt.pod, logger)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("DecodePodDevices() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("DecodePodDevices() = %+v, want %+v", got, tt.want)
+			}
+		})
+	}
+}