Skip to content

feat(chart): support appVersion as the default image tag#640

Open
xiongzubiao wants to merge 792 commits into
Project-HAMi:masterfrom
xiongzubiao:appVersion
Open

feat(chart): support appVersion as the default image tag#640
xiongzubiao wants to merge 792 commits into
Project-HAMi:masterfrom
xiongzubiao:appVersion

Conversation

@xiongzubiao

@xiongzubiao xiongzubiao commented Nov 22, 2024

Copy link
Copy Markdown

What type of PR is this?

/kind feature

What this PR does / why we need it:

It is common that helm charts use the Chart.AppVersion as the default image tag. This PR adds support for it, while still allowing one to customize it via Values.version.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

archlitchi and others added 30 commits May 23, 2024 17:47
Signed-off-by: wawa0210 <xiao.zhang@daocloud.io>
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: wawa0210 <xiao.zhang@daocloud.io>
Bumps ubuntu from 20.04 to 24.04.

---
updated-dependencies:
- dependency-name: ubuntu
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: wawa0210 <xiao.zhang@daocloud.io>
…evice-plugin crashes. (Project-HAMi#328)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
* 💡 Add Benchmark build script and deployment files

Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>

* address latest comment

Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>

* Update Dockerfile to use the correct repository for cloning the ai-benchmark project

Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>

---------

Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>
Signed-off-by: coderth <coderth@outlook.com>
Signed-off-by: rongfu.leng <lenronfu@gmail.com>
…roject-HAMi#350)

* fix: typo in use_exclusive_card.yaml and add new exclusive example

Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>

* fix: typo in scheduler

Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>

---------

Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>
Signed-off-by: rongfu.leng <lenronfu@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.22.0 to 0.26.0.
- [Commits](golang/net@v0.22.0...v0.26.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.7.0...v1.8.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…amespaces (Project-HAMi#364)

The code changes in `webhook.yaml` modify the namespace whitelist for the webhook. The `kube-system` and `istio-system` namespaces are added to the whitelist. This change aims to allow the webhook to function properly in these namespaces.

Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>
Co-authored-by: Tim Wang <tim.wang03@sap.com>
Fix HostGPUMemoryUsage wrong unit on grafana dashboard

Signed-off-by: joy717 <joy717.xmu@gmail.com>
Signed-off-by: rongfu.leng <lenronfu@gmail.com>
* feat: add liveness probe on scheduler extender

Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>

* feat: also add liveness probe on kube-scheduler

Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>

---------

Signed-off-by: wenqing.he <wenqinghe1016@gmail.com>
Signed-off-by: wawa0210 <xiao.zhang@daocloud.io>
@xiongzubiao

Copy link
Copy Markdown
Author

I force-pushed it to resolve the merging conflict. cc @wawa0210 @lengrongfu

archlitchi and others added 23 commits January 25, 2025 14:21
* update ci and logic

Signed-off-by: limengxuan <391013634@qq.com>
* update ci

Signed-off-by: limengxuan <391013634@qq.com>
* update ci

Signed-off-by: limengxuan <391013634@qq.com>
* update dockerfile

Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: wen.rui <wen.rui@daocloud.io>
…ore' GPU (Project-HAMi#848)

* fix scheduler crash on mig-mode task running on a hami-core gpu

Signed-off-by: limengxuan <391013634@qq.com>
…er (Project-HAMi#799)

Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>
Signed-off-by: jinye <jinye.shi@daocloud.io>
Signed-off-by: jinye <jinye.shi@daocloud.io>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.26.0 to 0.33.0.
- [Commits](golang/net@v0.26.0...v0.33.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.11.0 to 6.13.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v6.11.0...v6.13.0)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.26.0 to 0.35.0.
- [Commits](golang/net@v0.26.0...v0.35.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
Signed-off-by: 王然 <ranwang@alauda.io>
…tpl (Project-HAMi#845)

* Update condition to include regexReplaceAll for outputting proper numbers from minor versions

Signed-off-by: HJJ256 <harshjalan27@yahoo.com>

* Update condition

Signed-off-by: HJJ256 <harshjalan27@yahoo.com>

* Update definition of strippedKubeVersion to handle variety of version numbering systems

Signed-off-by: HJJ256 <harshjalan27@yahoo.com>

* Update job-createSecret.yaml

Signed-off-by: HJJ256 <harshjalan27@yahoo.com>

* Update job-patchWebhook.yaml

Signed-off-by: HJJ256 <harshjalan27@yahoo.com>

---------

Signed-off-by: HJJ256 <harshjalan27@yahoo.com>
* update libvgpu

Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: rockpanda <balladpanda@gmail.com>
Due to potential pod startup issues in certain environments,
set passDeviceSpecsEnabled to false by default.
This configuration can still be enabled via helm values
for environments that need it to handle runtime GPU access issues.

Signed-off-by: Nimbus318 <136771156+Nimbus318@users.noreply.github.com>
Signed-off-by: ouyangluwei <ouyangluwei@riseunion.io>
Co-authored-by: ouyangluwei <ouyangluwei@haodf.com>
Signed-off-by: jinvei <jinvei116@gmail.com>
Signed-off-by: Zubiao Xiong <zubiao.xiong@memverge.com>
@mesutoezdil

Copy link
Copy Markdown
Contributor

@wawa0210 @lengrongfu all feedback addressed and conflicts resolved since January 2025. Ready for approval.

@mesutoezdil

Copy link
Copy Markdown
Contributor

Hi,

We are going through open pull requests to keep things manageable. This PR was opened before 2026 and has not been merged or updated recently.

Please reply by 2026-07-13 to confirm this is still relevant and based on the current codebase. If we do not hear back, we will close this PR. You are welcome to reopen it or submit a new one when ready.

Thank you for your contribution to HAMi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.