Skip to content

Add env var and hostpath for container level metrics#7

Draft
dttung2905 wants to merge 2 commits into
Project-HAMi:mainfrom
dttung2905:inject-env-var-hostpath
Draft

Add env var and hostpath for container level metrics#7
dttung2905 wants to merge 2 commits into
Project-HAMi:mainfrom
dttung2905:inject-env-var-hostpath

Conversation

@dttung2905

Copy link
Copy Markdown

Implementing the kai-resource-isolator webhook part as outlined in this kai-scheduler/KAI-Scheduler#1821

TODO :

  • : add test

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@hami-robot

hami-robot Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dttung2905
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 79e48b3f-f385-4c05-8e89-740a84bc65ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hami-robot

hami-robot Bot commented Jul 14, 2026

Copy link
Copy Markdown

Welcome @dttung2905! It looks like this is your first PR to Project-HAMi/KAI-resource-isolator 🎉

@hami-robot hami-robot Bot added the size/L label Jul 14, 2026
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@hami-robot hami-robot Bot added size/XL and removed size/L labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant