Skip to content

fix: create ascend device plugin log path#90

Merged
hami-robot[bot] merged 1 commit into
Project-HAMi:mainfrom
fyuan1316:fix
Jun 30, 2026
Merged

fix: create ascend device plugin log path#90
hami-robot[bot] merged 1 commit into
Project-HAMi:mainfrom
fyuan1316:fix

Conversation

@fyuan1316

@fyuan1316 fyuan1316 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

close #89

Summary by CodeRabbit

  • Bug Fixes
    • Updated the device plugin configuration so the log directory is created automatically if it doesn’t already exist, reducing startup issues on fresh systems.

Signed-off-by: Yuan Fang <yuanfang@alauda.io>
@hami-robot

hami-robot Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Welcome @fyuan1316! It looks like this is your first PR to Project-HAMi/ascend-device-plugin 🎉

@hami-robot hami-robot Bot added the size/XS label Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b151eee7-bd40-4368-8c5f-c115893a8049

📥 Commits

Reviewing files that changed from the base of the PR and between 92ef213 and 0ea1386.

📒 Files selected for processing (1)
  • ascend-device-plugin.yaml

📝 Walkthrough

Walkthrough

In ascend-device-plugin.yaml, the hostPath.type for the log-path volume is changed from Directory to DirectoryOrCreate, so kubelet will create /var/log/mindx-dl/devicePlugin on the host if it does not already exist.

Ascend Device Plugin DaemonSet Manifest

Layer / File(s) Summary
log-path hostPath type
ascend-device-plugin.yaml
hostPath.type for the log-path volume changes from Directory to DirectoryOrCreate, allowing kubelet to create the directory when absent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A path that must exist — what a chore!
The kubelet would grumble, then show you the door.
Now DirectoryOrCreate saves the day,
The log folder blooms where none was before. 🐇
No pre-creation needed, hop on your way!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: creating the Ascend device plugin log path automatically.
Linked Issues check ✅ Passed The PR satisfies #89 by changing the log-path hostPath type from Directory to DirectoryOrCreate.
Out of Scope Changes check ✅ Passed The only code change is the requested hostPath type update, with no evident out-of-scope additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@DSFans2014 DSFans2014 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@archlitchi archlitchi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot

hami-robot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, fyuan1316

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot added the approved label Jun 30, 2026
@hami-robot hami-robot Bot merged commit ce9ab91 into Project-HAMi:main Jun 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hostPath log directory should use DirectoryOrCreate

3 participants