fix: correct register cores for HamiVnpuCore mode#91
Conversation
Signed-off-by: Jifei Wang <jifei.wang@dynamia.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds a new exported constant HamiVnpu Devcore override
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, FouoF The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently, the register annotation always register cores according to device preset. However, the vNPU core mod assume one device have 100 cores.
Although the scheduler has handled this inconsistency. It still effects the metrics thus it will be limit 8 and allocated 100.
This pr aims to correct this inconsistency.
Summary by CodeRabbit
New Features
Bug Fixes
Tests