Skip to content

fix: the configuration in the ConfigMap may be overwritten by command-line parameters#115

Closed
DSFans2014 wants to merge 1 commit intoProject-HAMi:mainfrom
DSFans2014:fix/config
Closed

fix: the configuration in the ConfigMap may be overwritten by command-line parameters#115
DSFans2014 wants to merge 1 commit intoProject-HAMi:mainfrom
DSFans2014:fix/config

Conversation

@DSFans2014
Copy link
Copy Markdown
Contributor

#98 tried to solve this problem but didn't completely fix it

Signed-off-by: james <open4pd@4paradigm.com>
@hami-robot
Copy link
Copy Markdown
Contributor

hami-robot Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DSFans2014
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DSFans2014 DSFans2014 changed the title fix: the configuration in the ConfigMap may be overwritten by command-line parameters fix: the configuration in the ConfigMap may be overwritten by command-line parameters Apr 22, 2026
@hami-robot hami-robot Bot added the size/XS label Apr 22, 2026
@DSFans2014
Copy link
Copy Markdown
Contributor Author

Here's a problem: if someone previously used the --gpu-memory-factor args to configure settings, it will no longer take effect after the upgrade. because it will be overwritten by the Configmap @archlitchi

@DSFans2014 DSFans2014 closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant