Skip to content

fix: correct errors in deploy-with-helm.md#503

Open
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/deploy-with-helm-fixes
Open

fix: correct errors in deploy-with-helm.md#503
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/deploy-with-helm-fixes

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
  • Helm link: zh URL replaced with en
  • kubectl version: v1.16+ updated to v1.23+ to match prerequisites.md
  • Node label: {nodeid} replaced with
  • kubectl exec: added missing -- before nvidia-smi

Summary by CodeRabbit

  • Documentation
    • Updated Helm deployment prerequisites with clearer version guidance.
    • Increased the recommended minimum kubectl version for setup instructions.
    • Simplified the node-labeling example to use a generic node name placeholder.
    • Improved the demo verification command format for more reliable command execution.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@hami-robot

hami-robot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e095265c-1078-48da-909e-440804001858

📥 Commits

Reviewing files that changed from the base of the PR and between a3e36d4 and 1bbf6d1.

📒 Files selected for processing (1)
  • docs/get-started/deploy-with-helm.md

📝 Walkthrough

Walkthrough

The Helm deployment guide updates prerequisite versions and adjusts example commands for node labeling and container verification.

Changes

Helm deployment guide

Layer / File(s) Summary
Prerequisites and example commands
docs/get-started/deploy-with-helm.md
The guide updates the Helm and kubectl prerequisite bullets, changes the node label placeholder to <node-name>, and adds -- to the kubectl exec example.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hops through Helm docs bright,
🐰 labels tidy, commands right.
v3 shells and kubectl now align,
With -- for nvidia-smi in time.
Soft thumps, neat jumps, all feels fine.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the documentation fixes in deploy-with-helm.md.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@hami-robot hami-robot Bot added the size/XS label Jun 26, 2026
@netlify

netlify Bot commented Jun 26, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 1bbf6d1
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a3ecdb326b4710008efddb7
😎 Deploy Preview https://deploy-preview-503--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant