Skip to content

fix: replace {nodeid} and add helm repo update to installation docs#504

Open
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/installation-fixes
Open

fix: replace {nodeid} and add helm repo update to installation docs#504
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/installation-fixes

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
  • prerequisites.md: {nodeid} replaced with
  • online-installation.md: add helm repo update after helm repo add

Summary by CodeRabbit

  • Documentation
    • Clarified the installation steps by adding a repository update command after adding the Helm chart source.
    • Improved the node-labeling example to use a clearer placeholder for the node name when enabling GPU support.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@hami-robot

hami-robot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign windsonsea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dd6258bb-a1fd-4981-85a2-7afe60d4c091

📥 Commits

Reviewing files that changed from the base of the PR and between a3e36d4 and eb38e92.

📒 Files selected for processing (2)
  • docs/installation/online-installation.md
  • docs/installation/prerequisites.md

📝 Walkthrough

Walkthrough

The installation docs now add helm repo update after adding the Helm chart repo, and the prerequisites example changes the GPU node label placeholder from {nodeid} to <node-name>.

Changes

Installation docs updates

Layer / File(s) Summary
Installation command examples
docs/installation/online-installation.md, docs/installation/prerequisites.md
The Helm repo instructions add helm repo update, and the prerequisites example changes the node label placeholder to <node-name>.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hopped by with a joyful thump,
helm repo update gave the docs a jump.
One label got tidy, one step got bright,
Now installation hops along just right. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the documentation updates: replacing {nodeid} and adding helm repo update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@hami-robot hami-robot Bot added the size/XS label Jun 26, 2026
@netlify

netlify Bot commented Jun 26, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit eb38e92
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a3ecdd225aca90008fe395a
😎 Deploy Preview https://deploy-preview-504--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant