Skip to content

docs: remove manual kubeScheduler image tag specification#558

Merged
hami-robot[bot] merged 1 commit into
Project-HAMi:masterfrom
DSFans2014:docs/deploy
Jul 6, 2026
Merged

docs: remove manual kubeScheduler image tag specification#558
hami-robot[bot] merged 1 commit into
Project-HAMi:masterfrom
DSFans2014:docs/deploy

Conversation

@DSFans2014

@DSFans2014 DSFans2014 commented Jul 6, 2026

Copy link
Copy Markdown
Member

The Kubernetes version is automatically detected by Helm during installation and does not need to be manually specified.

fix Project-HAMi/HAMi#1991

Summary by CodeRabbit

  • Documentation
    • Updated the Helm install guide to include a complete baseline install command after refreshing the Helm repository.
    • Clarified the setup flow so users can run a plain install first, then follow the version-specific example when needed.
    • Applied the same documentation update across all supported language and versioned guides.

Signed-off-by: james <open4pd@4paradigm.com>
@netlify

netlify Bot commented Jul 6, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 8e38d2a
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a4b1f038c22d30008ccb35f
😎 Deploy Preview https://deploy-preview-558--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot hami-robot Bot added the size/M label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b06f52c-17e7-4456-bc3a-678474134970

📥 Commits

Reviewing files that changed from the base of the PR and between a7ddc31 and 8e38d2a.

📒 Files selected for processing (7)
  • docs/get-started/deploy-with-helm.md
  • i18n/zh/docusaurus-plugin-content-docs/version-v2.7.0/get-started/deploy-with-helm.md
  • i18n/zh/docusaurus-plugin-content-docs/version-v2.8.0/get-started/deploy-with-helm.md
  • i18n/zh/docusaurus-plugin-content-docs/version-v2.9.0/get-started/deploy-with-helm.md
  • versioned_docs/version-v2.7.0/get-started/deploy-with-helm.md
  • versioned_docs/version-v2.8.0/get-started/deploy-with-helm.md
  • versioned_docs/version-v2.9.0/get-started/deploy-with-helm.md

📝 Walkthrough

Walkthrough

This PR updates Helm deployment instructions across the main docs, versioned docs (v2.7.0, v2.8.0, v2.9.0), and their zh i18n translations. It adds a baseline helm install hami hami-charts/hami -n kube-system command and, in v2.7.0, removes an incorrect scheduler.kubeScheduler.imageTag parameter usage.

Changes

Helm Install Documentation Updates

Layer / File(s) Summary
Main docs baseline install command
docs/get-started/deploy-with-helm.md
Adds a baseline helm install hami hami-charts/hami -n kube-system command after repo add/update steps.
Versioned docs install command fixes
versioned_docs/version-v2.7.0/..., versioned_docs/version-v2.8.0/..., versioned_docs/version-v2.9.0/get-started/deploy-with-helm.md
Adds baseline install command to v2.8.0 and v2.9.0; v2.7.0 replaces the incorrect --set scheduler.kubeScheduler.imageTag=... example with a plain install command.
zh i18n translated docs updates
i18n/zh/docusaurus-plugin-content-docs/version-v2.7.0/..., version-v2.8.0/..., version-v2.9.0/get-started/deploy-with-helm.md
Mirrors the helm repo update and baseline install command additions in zh translations for all three versions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • Project-HAMi/website#425: Both PRs update the same docs/get-started/deploy-with-helm.md Helm command sequence, adding/adjusting the helm repo update step after adding the hami-charts repository.

Suggested labels: lgtm, approved

Suggested reviewers: archlitchi, rootsongjc

Poem

A hop, a skip, a helm install line,
The docs now match the cluster fine.
No more imageTag gone astray,
Just helm install to save the day.
🐇 Thump thump — ship it, hooray!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR removes the imageTag example instead of correcting the documented parameter to scheduler.kubeScheduler.image.tag as requested in #1991. Update the installation docs to replace scheduler.kubeScheduler.imageTag with scheduler.kubeScheduler.image.tag wherever the parameter is documented.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the primary doc change: removing the manual kubeScheduler image tag specification.
Out of Scope Changes check ✅ Passed All changes stay within the Helm installation docs and relate to the documented installation flow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@hami-robot

hami-robot Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DSFans2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot merged commit 7f15342 into Project-HAMi:master Jul 6, 2026
12 checks passed
@DSFans2014 DSFans2014 deleted the docs/deploy branch July 6, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant