fix: address bugs found in code review

- base/settings: correct misspelled "DefaultOuputFileExtension" key so
  the user's chosen output extension actually round-trips on save/load
- base/settings.h: drop unimplemented temporaryPath() declaration
- base/LemonBaseApplication: invert parseCommandLine() return so the
  hasError branch fires on real errors instead of on success; release
  the locally-allocated Settings before returning
- base/LemonLog: move tempBuffer/tempStream into log_concat() so
  concurrent log calls no longer race on shared globals
- base/LemonTranslator: bail out when QTranslator::load() fails instead
  of installing an empty translator
- core/processrunner_win: fix uniform_int_distribution upper bound
  (was inclusive of length(), allowing an out-of-range index)
- generalsettings: actually return false from checkValid() when
  rejudgeTimes is empty so invalid input is rejected
- lemon: return after the "No Contest Yet" warning in changeContestName
  to avoid dereferencing a null curContest

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
(cherry picked from commit a6f010d)

Author: alphagocc

src/base/LemonBaseApplication.cpp

@@ -22,7 +22,7 @@ using namespace Lemon;
 auto LemonBaseApplication::Initialize() -> bool {
 	QString errorMessage;
 	bool canContinue;
-	const auto hasError = parseCommandLine(&canContinue, &errorMessage);
+	const auto hasError = ! parseCommandLine(&canContinue, &errorMessage);
 	if (hasError) {
 		LOG("Command line: " GEN_PAIR(errorMessage));
 		if (! canContinue) {
@@ -48,7 +48,7 @@ auto LemonBaseApplication::Initialize() -> bool {
 		}
 	}
 	LemonLimeTranslator->InstallTranslation(settings->getUiLanguage());
-
+	delete settings;
 	return true;
 }
 

src/base/LemonLog.hpp

@@ -48,10 +48,10 @@ Q_DECLARE_METATYPE(const char *)
 
 namespace Lemon::base {
 	inline std::shared_ptr<spdlog::logger> logger;
-	inline QString tempBuffer;
-	inline QTextStream tempStream{&tempBuffer};
 
 	template <LemonLogType t, typename... T> inline void log_concat(T... v) {
+		QString tempBuffer;
+		QTextStream tempStream{&tempBuffer};
 		((tempStream << v << " "), ...);
 
 		const auto logString = tempStream.readAll().toStdString();

src/base/LemonTranslator.cpp

@@ -55,6 +55,7 @@ namespace Lemon::common {
 				bool success = translatorNew->load(code + ".qm", path);
 				if (! success) {
 					LOG("Cannot load translation: " + code);
+					return false;
 				}
 				if (pTranslator) {
 					LOG("Removed translations");

src/base/settings.cpp

@@ -533,7 +533,7 @@ void Settings::loadSettings() {
 	rejudgeTimes = settings.value("MaximumRejudgeTimes", 1).toInt();
 	maxJudgingThreads = settings.value("MaximumJudgingThreads", 1).toInt();
 	defaultInputFileExtension = settings.value("DefaultInputFileExtension", "in").toString();
-	defaultOutputFileExtension = settings.value("DefaultOuputFileExtension", "out").toString();
+	defaultOutputFileExtension = settings.value("DefaultOutputFileExtension", "out").toString();
 	inputFileExtensions = settings.value("InputFileExtensions", QStringList() << "in").toStringList();
 	outputFileExtensions =
 	    settings.value("OutputFileExtensions", QStringList() << "out" << "ans").toStringList();

src/base/settings.h

@@ -142,7 +142,6 @@ class Settings {
 	static double upperBoundForExtraTimeRatio();
 	static QString dataPath();
 	static QString sourcePath();
-	static QString temporaryPath();
 	static QString selfTestPath();
 
   private:

src/core/processrunner_win.cpp

@@ -39,7 +39,8 @@ namespace {
 		    "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789");
 		std::mt19937 gen(std::random_device{}());
 
-		std::uniform_int_distribution<int> rand(0, possibleCharacters.length());
+		std::uniform_int_distribution<int> rand(0, // [0, length of possibleCharacters - 1]
+		                                        possibleCharacters.length() - 1);
 		QString randomString;
 		for (int i = 0; i < length; ++i) {
 			int index = rand(gen) % possibleCharacters.length();

src/generalsettings.cpp

@@ -131,6 +131,7 @@ auto GeneralSettings::checkValid() -> bool {
 	if (ui->rejudgeTimes->text().isEmpty()) {
 		ui->rejudgeTimes->setFocus();
 		QMessageBox::warning(this, tr("Error"), tr("Empty maximum rejudge times!"), QMessageBox::Close);
+		return false;
 	}
 
 	return true;

src/lemon.cpp

@@ -879,8 +879,8 @@ void LemonLime::addTaskWithScoreScale(const QString &title,
 	}
 }
 
-auto LemonLime::compareFileName(const std::pair<QString, QString> &a,
-                                const std::pair<QString, QString> &b) -> bool {
+auto LemonLime::compareFileName(const std::pair<QString, QString> &a, const std::pair<QString, QString> &b)
+    -> bool {
 	return (a.first.length() < b.first.length()) ||
 	       (a.first.length() == b.first.length() && QString::localeAwareCompare(a.first, b.first) < 0);
 }
@@ -972,6 +972,7 @@ void LemonLime::exportStatistics() { StatisticsBrowser::exportStatistics(this, c
 void LemonLime::changeContestName() {
 	if (! curContest) {
 		QMessageBox::warning(this, tr("Rename Contest"), tr("No Contest Yet"));
+		return;
 	}
 
 	bool confirmed = false;