Skip to content

Commit bc422e3

Browse files
committed
Disable coverage tests, return to coverage testing later to run as a job and in PRs
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
1 parent 6d4e1f2 commit bc422e3

2 files changed

Lines changed: 56 additions & 56 deletions

File tree

.github/workflows/cron-ngc-bundle.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
name: cron-ngc-bundle
33

44
on:
5-
pull_request:
6-
branches:
7-
- dev # temporary for testing in the PR
85
schedule:
96
- cron: "0 2 * * *" # at 02:00 UTC
107
# Allows you to run this workflow manually from the Actions tab

.github/workflows/setupapp.yml

Lines changed: 56 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@ name: deploy
33

44
on:
55
# full tests for all the important branches
6-
push:
7-
branches:
8-
- main
9-
- releasing/*
10-
- feature/*
11-
- dev
12-
pull_request:
13-
branches:
14-
- dev # temporary for testing in the PR
6+
# push:
7+
# branches:
8+
# - main
9+
# - releasing/*
10+
# - feature/*
11+
# - dev
12+
13+
# Allows you to run this workflow manually from the Actions tab
14+
workflow_dispatch:
1515

1616
concurrency:
1717
# automatically cancel the previously triggered workflows when there's a newer version
@@ -24,6 +24,8 @@ jobs:
2424
# - ubuntu 37 38 39 310-pip-
2525
# - os-latest-pip (shared)
2626

27+
# TODO: coverage should be re-enable at a future time in PRs as well as longer running jobs, ideally with GPU support
28+
2729
# coverage-py3:
2830
# # if: github.repository == 'Project-MONAI/MONAI'
2931
# if: ${{ false }} # disable self-hosted job project-monai/monai#7039
@@ -81,51 +83,52 @@ jobs:
8183
# fail_ci_if_error: false
8284
# files: ./coverage.xml
8385

84-
test-py3x:
85-
runs-on: ubuntu-latest
86-
strategy:
87-
matrix:
88-
python-version: ['3.10', '3.11', '3.12']
89-
steps:
90-
- uses: actions/checkout@v6
91-
with:
92-
fetch-depth: 0
93-
- name: Set up Python ${{ matrix.python-version }}
94-
uses: actions/setup-python@v6
95-
with:
96-
python-version: ${{ matrix.python-version }}
97-
cache: pip
98-
- name: Install CPU PyTorch
99-
run: |
100-
python -m pip install --upgrade pip wheel wheel-stub
101-
python -m pip install torch==2.8.0 torchvision --extra-index-url https://download.pytorch.org/whl/cpu
102-
- name: Install the dependencies
103-
run: |
104-
find /opt/hostedtoolcache/* -maxdepth 0 ! -name 'Python' -exec rm -rf {} \;
105-
python -m pip install --no-build-isolation -r requirements-min.txt # necessary only here for some reason?
106-
python -m pip install --no-build-isolation -r requirements-dev.txt
107-
- name: Run quick tests CPU ubuntu
108-
env:
109-
NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
110-
NGC_ORG: ${{ secrets.NGC_ORG }}
111-
NGC_TEAM: ${{ secrets.NGC_TEAM }}
112-
TRANSFORMERS_VERBOSITY: error # stifle huggingface transformers warnings about aliases
113-
run: |
114-
python -m pip list
115-
python -c 'import torch; print(torch.__version__); print(torch.rand(5,3))'
116-
BUILD_MONAI=0 python -m pip install --no-build-isolation -e .
117-
./runtests.sh --coverage --quick --unittests --disttests
86+
87+
# test-py3x:
88+
# runs-on: ubuntu-latest
89+
# strategy:
90+
# matrix:
91+
# python-version: ['3.10', '3.11', '3.12']
92+
# steps:
93+
# - uses: actions/checkout@v6
94+
# with:
95+
# fetch-depth: 0
96+
# - name: Set up Python ${{ matrix.python-version }}
97+
# uses: actions/setup-python@v6
98+
# with:
99+
# python-version: ${{ matrix.python-version }}
100+
# cache: pip
101+
# - name: Install CPU PyTorch
102+
# run: |
103+
# python -m pip install --upgrade pip wheel wheel-stub
104+
# python -m pip install torch==2.8.0 torchvision --extra-index-url https://download.pytorch.org/whl/cpu
105+
# - name: Install the dependencies
106+
# run: |
107+
# find /opt/hostedtoolcache/* -maxdepth 0 ! -name 'Python' -exec rm -rf {} \;
108+
# python -m pip install --no-build-isolation -r requirements-min.txt # necessary only here for some reason?
109+
# python -m pip install --no-build-isolation -r requirements-dev.txt
110+
# - name: Run quick tests CPU ubuntu
111+
# env:
112+
# NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
113+
# NGC_ORG: ${{ secrets.NGC_ORG }}
114+
# NGC_TEAM: ${{ secrets.NGC_TEAM }}
115+
# TRANSFORMERS_VERBOSITY: error # stifle huggingface transformers warnings about aliases
116+
# run: |
117+
# python -m pip list
118+
# python -c 'import torch; print(torch.__version__); print(torch.rand(5,3))'
119+
# BUILD_MONAI=0 python -m pip install --no-build-isolation -e .
120+
# ./runtests.sh --coverage --quick --unittests --disttests
118121

119-
# TODO: update installation process to allow testing with and without compiled libraries as intended here
120-
#BUILD_MONAI=0 ./runtests.sh --build --coverage --quick --unittests
121-
#./runtests.sh --clean
122-
#BUILD_MONAI=1 ./runtests.sh --build --coverage --quick --min
123-
coverage xml --ignore-errors
124-
- name: Upload coverage
125-
uses: codecov/codecov-action@v6
126-
with:
127-
fail_ci_if_error: false
128-
files: ./coverage.xml
122+
# # TODO: update installation process to allow testing with and without compiled libraries as intended here
123+
# #BUILD_MONAI=0 ./runtests.sh --build --coverage --quick --unittests
124+
# #./runtests.sh --clean
125+
# #BUILD_MONAI=1 ./runtests.sh --build --coverage --quick --min
126+
# coverage xml --ignore-errors
127+
# - name: Upload coverage
128+
# uses: codecov/codecov-action@v6
129+
# with:
130+
# fail_ci_if_error: false
131+
# files: ./coverage.xml
129132

130133
install: # pip install from github url, the default branch is dev
131134
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)