Project and doc changes to get ready to release 3.1 minor update#551
Conversation
… v3.6 due to MONAI v1.5 limits torch <2.7, and the installed torch 2.6 has an older version of the cuda12 runtime, libcudart.so.12 at 12.4 which is not compatible with HSDK v3.6 (CUDA >=12.6.77). So need to limit HSDK dependency to ~=3.5.0 Signed-off-by: M Q <mingmelvinq@nvidia.com>
… doc build. Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
|
MMelQin
changed the title
There was a problem hiding this comment.
Pull Request Overview
Updates MONAI Deploy App SDK dependencies and tooling for the 3.1 release, addressing compatibility issues between Holoscan SDK v3.6 and MONAI v1.5's torch dependency constraints.
- Pin Holoscan SDK to v3.5.x to resolve CUDA runtime conflicts with torch 2.6
- Update Python tooling configuration to support Python 3.13 and default to Python 3.10
- Add v3.1.0 to release notes documentation
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.cfg | Pin Holoscan SDK dependencies to v3.5.0 to address CUDA compatibility |
| pyproject.toml | Update Black formatter to support Python 3.13 and remove deprecated Python 3.8 |
| docs/source/release_notes/index.md | Add v3.1.0 entry to release notes table of contents |
| .github/workflows/pr.yml | Update CI workflow to use Python 3.10 instead of 3.9 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| holoscan~=3.0 | ||
| holoscan-cli~=3.0 | ||
| holoscan<=3.5.0 | ||
| holoscan-cli<=3.5.0 |
There was a problem hiding this comment.
Using <=3.5.0 allows potentially incompatible patch versions above 3.5.0. Based on the PR description mentioning compatibility issues with v3.6, consider using holoscan~=3.5.0 or holoscan>=3.0,<3.6 to be more explicit about the version range and prevent issues with future 3.5.x releases.
| holoscan-cli<=3.5.0 | |
| holoscan-cli>=3.0,<3.6 |
Updates dependency versions and docs to prepare for the 3.1 minor release, specifically pinning Holoscan SDK to v3.5.x to address compatibility issues with v3.6 due to CUDA runtime version conflicts.
MONAI Deploy App SDK is not compatible with Holoscan SDK v3.6 due to MONAI v1.5 limits torch <2.7 and as such torch 2.6 is installed in the Python environment. Torch 2.6 is bundled with an older version of the cuda12 runtime, libcudart.so.12 at 12.4, which is not compatible with HSDK v3.6 (CUDA >=12.6.77).
So, App SDK needs to limit HSDK dependency to <=3.5.0.