-
Notifications
You must be signed in to change notification settings - Fork 1
BUG:ACCESS_VIOLATION crashes and NumPy shape bug in 4D CT pipeline #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7047d9a
ac9c44c
16e089c
75245ff
e8f2ca3
4008048
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -221,6 +221,8 @@ show_error_codes = true | |
| module = [ | ||
| "ants", | ||
| "cupy", | ||
| "cupy_backends", | ||
| "cupy_backends.*", | ||
| "icon_registration", | ||
| "icon_registration.*", | ||
| "itk", | ||
|
|
@@ -270,6 +272,12 @@ module = [ | |
| ] | ||
| disable_error_code = ["import-not-found", "import-untyped"] | ||
|
|
||
| [[tool.mypy.overrides]] | ||
| # torch/icon_registration/unigradicon are lazy-loaded at runtime; string | ||
| # forward-reference annotations like "torch.Size" are intentional. | ||
| module = ["physiomotion4d.register_images_icon"] | ||
| ignore_errors = true | ||
|
Comment on lines
+275
to
+279
|
||
|
|
||
|
Comment on lines
+275
to
+280
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid blanket type/lint suppression for Lines 273-278 ( As per coding guidelines, "Use full type hints with Also applies to: 407-408 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| [tool.pyright] | ||
| # Third-party packages (e.g. pyvista) are in dependencies but may have no stubs; | ||
| # do not report import-not-found so analysis matches mypy overrides above. | ||
|
|
@@ -398,6 +406,8 @@ ignore = [ | |
| "test_*.py" = ["S101", "PLR2004", "ARG001", "ARG002"] | ||
| "tests/*.py" = ["S101", "PLR2004", "ARG001", "ARG002"] | ||
| "experiments/**/*.py" = ["T201", "S101"] | ||
| # torch/icon_registration are lazy-loaded at runtime; forward-reference strings are intentional | ||
| "src/physiomotion4d/register_images_icon.py" = ["F821"] | ||
|
|
||
| [tool.ruff.lint.isort] | ||
| known-first-party = ["physiomotion4d"] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synchronize the remaining registration terminology in this README.
You updated this section to labelmap-based wording, but Line 250 still describes the same workflow as “mask-based,” which leaves conflicting guidance in one document.
🤖 Prompt for AI Agents