fix: consolidate h2 spacing, drop invalid focus border-radius, dynamic versioning, uppercase strategy constants, strengthen cycle/key assertions#39
Draft
Nelson Spence (Fieldnote-Echo) with Copilot wants to merge 2 commits into
Conversation
…importlib.metadata for version, uppercase strategy constants, and strengthen walk/cycle test assertions Agent-Logs-Url: https://github.com/Project-Navi/navi-sanitize/sessions/04c15fd9-0f06-4339-8873-5d1581ce868d Co-authored-by: Fieldnote-Echo <202828230+Fieldnote-Echo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix h2 styling to consolidate spacing
fix: consolidate h2 spacing, drop invalid focus border-radius, dynamic versioning, uppercase strategy constants, strengthen cycle/key assertions
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven targeted fixes addressing CSS visual-hierarchy bugs, a hardcoded version string, mutable module-level test constants, and incomplete test assertions in
walk().CSS (
docs/stylesheets/navi.css)padding-bottomwas0.75remand::afterhadmargin-top: 0.75rem— 1.5rem total gap split across two properties. Consolidated topadding-bottom: 1.5rem+ removedmargin-topfrom::after.:focus-visible: Removedborder-radius: 3px— CSSoutlinedoes not respectborder-radius; the property was silently ignored.Versioning (
src/navi_sanitize/__init__.py)__version__ = "0.2.1"withimportlib.metadatalookup; falls back to"0.0.0"on bare source checkouts where package metadata is absent.Tests (
tests/test_properties.py)hostile_text / unicode_text / safe_text→HOSTILE_TEXT / UNICODE_TEXT / SAFE_TEXTto signal immutable module-level constants.test_handles_cycle: added fullclean()invariant assertions on the leaf value (no null bytes, no invisible chars, no homoglyphs, NFKC-stable).Tests (
tests/test_walk.py)assert result is not data— verifieswalk()returns a new dict even when tuple values are not traversed."n\u0430me","\x00key","inner\u200b") are absent from the result, not just that sanitized keys exist.Original prompt