Fix geocoder close button click-through to map (#409)

* Fix geocoder close button click-through to map (fixes #375)

- Add src/geocoder_patches.js to monkey-patch the leaflet-routing-machine geocoder
- Stop click propagation on the .leaflet-routing-geocoders container
- Prevents unintended waypoint creation when closing geocoder entries
- Preserves close button functionality while blocking map interaction

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update package-lock.json

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: DennisOSRM

.DS_Store

@@ -25,7 +25,7 @@
     "routing",
     "api"
   ],
-  "author": "amy lee walton",
+  "author": "OSRM contributors",
   "jest": {
     "testEnvironment": "node",
     "testMatch": [
@@ -51,6 +51,6 @@
     "leaflet.locatecontrol": "^0.89.0",
     "local-storage": "^2.0.0",
     "osrm-text-instructions": "^0.15.0",
-    "qs": "^6.15.0"
+    "qs": "^6.15.1"
   }
 }

bundle.js

@@ -18,6 +18,16 @@ var geocoder = function(i, num) {
     name = String.fromCharCode(65 + i),
     icon = L.DomUtil.create('div', 'leaflet-osrm-geocoder-label', label);
   icon.innerHTML = name;
+  
+  // Disable click propagation on the entire container to prevent any clicks from bubbling to the map
+  L.DomEvent.disableClickPropagation(container);
+  
+  // Also explicitly handle click on the close button
+  L.DomEvent.on(close, 'click', function(e) {
+    e.stopPropagation();
+    e.preventDefault();
+  });
+  
   return {
     container: container,
     input: input,

bundle.js.map

@@ -0,0 +1,29 @@
+'use strict';
+
+var L = require('leaflet');
+
+/**
+ * Patches for geocoder widgets to prevent click propagation to the map.
+ * Without this patch, clicks on geocoder elements (especially the close button)
+ * bubble up to the map and trigger waypoint creation at the cursor position.
+ */
+module.exports = function() {
+  // Patch the main geocoders container to prevent click propagation
+  var patchGeocodersContainer = setInterval(function() {
+    var geocoderContainers = document.querySelectorAll('.leaflet-routing-geocoders');
+    if (geocoderContainers.length > 0) {
+      geocoderContainers.forEach(function(container) {
+        if (!container._clickPropagationPatched) {
+          L.DomEvent.disableClickPropagation(container);
+          // Also explicitly stop click events from propagating up to the map
+          L.DomEvent.on(container, 'click', function(e) {
+            e.stopPropagation();
+          });
+          container._clickPropagationPatched = true;
+        }
+      });
+      clearInterval(patchGeocodersContainer);
+    }
+  }, 100);
+};
+

package-lock.json

@@ -4,6 +4,8 @@ var L = require('leaflet');
 var routerPatches = require('./router_patches');
 var createGeocoder = require('./geocoder');
 require('leaflet-control-geocoder');
+var geocoderPatches = require('./geocoder_patches');
+geocoderPatches();
 var LRM = require('leaflet-routing-machine');
 // leaflet.locatecontrol@0.89 UMD has a bug: after the CJS IIFE it tries
 // `window.L.Control.Locate.locate` but never sets L.Control.Locate in the