fix: respect browser language preference#442
Merged
DennisOSRM merged 2 commits intogh-pagesfrom May 3, 2026
Merged
Conversation
Remove default OSRM_LANGUAGE so browser language detection is used when no config.json provides a language. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates language handling so the app no longer hardcodes English by default and can use the merged runtime language instead.
Changes:
- Remove the default
OSRM_LANGUAGE: 'en'entry from the staticwindow.OSRMconfig inindex.html. - Pass
mergedOptions.languageinto the routing control instead of forcing'en'insrc/index.js.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.js | Stops forcing English in the routing control and uses the merged language option. |
| index.html | Removes the baked-in default language from the bootstrap config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DennisOSRM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove default OSRM_LANGUAGE from index.html so browser/URL-configured language is used when available.
This allows Accept-Language detection to select the appropriate localization when no runtime config sets the language.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com